TWINE: The movement of the meca penguin is different from dos version

[mgerhardy]

This issue was reported on the lba discord:

---

This is how it works in the original dos version and how it always worked. (screencast 192921)

This is what it does in the scummvm version (screencast 193231)

I am 100% sure it did not meander in lba1
That's the way I've been passing the Temple of BU puzzle since 94
Stand on the pressure plate, move a few steps back, release the penguin
and then go wait by the door

it does go straight, just in the wrong direction

---

there are different opinions about the issue - the meca penguin has random movement assigned - so it should meander

Still needs investigation.

[mgerhardy]

change_scene 8
toggle_freecamera - scroll with syxc-keys (wasd like) to the location in the videos and hit v
give_allitems (to have the meca penguin)

[mgerhardy]

99164665ba09fb09f6e855dbf1efb0faf33c250d fixed using the wrong penguin angle at spawn - but it still doesn't behave as shown in the video of the dosbox run.

[mgerhardy]

TwinEEngine::processInventoryAction() case kiPenguin

[mgerhardy]

after spawning the penguin is doing a rotation. that is unexpected.

[mgerhardy]

actor->brickCausesDamage() returns true for the penguin. Looks like the issue might also be connected to the tank issue in https://bugs.scummvm.org/ticket/13177

[mgerhardy]

a hack is in place now - see ​https://github.com/scummvm/scummvm/commit/39d60856aaca25a2a609b7f15727e0f6aced592b

bIsFalling being 1 results in calls for doDir() which in turn rotates the penguin

[mgerhardy]

the life script lINIT_PINGOUIN would have set that actor to dead - but unfortunately the collision detection was executed already for that actor and Animations::doAnim set the bIsFalling to true.

[mgerhardy]

The issue only happens on the first penguin spawn - I've removed the hack to test this again and noticed that when I give myself the penguin again and spawn it a second time the movement is correct.

[mgerhardy]

In f13f308a:

TWINE: The movement of the meca penguin is different from dos version

fixed issue 13731 (https://bugs.scummvm.org/ticket/13731)