CHEWY: Videos are glitching in and out

[afreickmann]

The video cutscenes are usually glitching into the game, often with a 1 frame black screen or off-color frame. I also noticed that the game has several types of fade to black transitions, which are not yet present in the ScummVM version.

Examples:
​https://youtube.com/clip/UgkxVidG9oHbkZUENr8qyevTlBcjQtj45Gn2
​https://youtube.com/clip/Ugkx83eEcrwarshmcXUOeiT0WPPTI1oOHYUn

[eriktorbjorn]

If you mean like the glitch early in the intro (when it goes from the "Featuring Chewy" screen into the spaceships scene), there seem to be two things going on there:

1. These are two different videos, one played right after the other. At the end of a video, it will restore to the original palette, but when it does so the last frame of the previous video is still on screen apparently? One possible solution would be to clear the screen before resetting the palette at the end of the VideoPlayer::playVideo() function.

2. The second video is initiated by the playIntroSequence() function. One of the first things that does is to call setupScreen(DO_SETUP). I'm not familiar with this engine, so I don't know what the purpose of it is. But it looks to me like this will draw the current room, making it visible for a split second before the video begins. Should the call be there? If so, should it set the "disableScreen" flag to prevent it from drawing anything?