Opened 8 weeks ago

Last modified 8 weeks ago

#13587 new defect

The game save is not loaded in the correct save position.

Reported by: windlepoons Owned by: neuromancer
Priority: normal Component: Engine: Hypno
Version: Keywords: Save game
Cc: Game: Marvel Comics Spider-Man: The Sinister Six

Description

When I save a save game after a puzzle and load it, I am before the puzzle and not after.

Example 'SP' puzzle attached.

Marvel Comics Spider-Man: The Sinister Six (German version)
ScummVM 2.6.0pre99-gbdc149bd5e8 (Jun 16 2022 06:47:23)
OS: Siduction (Debian/sid)

Attachments (8)

sinistersix-de.012 (11.9 KB ) - added by windlepoons 8 weeks ago.
sinistersix-de.011 (15.2 KB ) - added by windlepoons 8 weeks ago.
sinistersix-de-SP.png (141.0 KB ) - added by windlepoons 8 weeks ago.
sinistersix-de.010 (16.2 KB ) - added by windlepoons 8 weeks ago.
sinistersix-de.009 (10.9 KB ) - added by windlepoons 8 weeks ago.
sinistersix-face.png (62.8 KB ) - added by windlepoons 8 weeks ago.
Hint for face puzzle
sinistersix-de.021 (11.6 KB ) - added by windlepoons 8 weeks ago.
sinistersix-de.020 (11.7 KB ) - added by windlepoons 8 weeks ago.

Download all attachments as: .zip

Change History (16)

by windlepoons, 8 weeks ago

Attachment: sinistersix-de.012 added

by windlepoons, 8 weeks ago

Attachment: sinistersix-de.011 added

by windlepoons, 8 weeks ago

Attachment: sinistersix-de-SP.png added

comment:1 by neuromancer, 8 weeks ago

Hey, thanks for the bug report. Just to clarify, you save the game after completing the puzzle or before completing it?

in reply to:  1 comment:2 by windlepoons, 8 weeks ago

Replying to neuromancer:

Hey, thanks for the bug report. Just to clarify, you save the game after completing the puzzle or before completing it?

Before the puzzle, and after the completing puzzles (= new scene, then saving).

comment:3 by neuromancer, 8 weeks ago

I think it should be solved here: https://github.com/scummvm/scummvm/commit/4cd06a5022db66b5b6e0106300b6b692798878d8

However, that is in master, and according to the information you provided, you are using a binary from 2.6.0 release candidate. This is fine, but we should confirm the fix in master before.

So I need you to compile latest master branch and re-test. The saved games *should* be compatible between 2.6.0 and master.

When you confirm the issue, I will proceed to fix it for the rest of the hardcoded puzzles, because I think it affects others as well. Once this is confirmed, I will cherry pick that fix into 2.6.0 for the upcoming release. Let me know if you need help with instructions on how to compile it (or you can wait for tomorrow's daily build)

by windlepoons, 8 weeks ago

Attachment: sinistersix-de.010 added

by windlepoons, 8 weeks ago

Attachment: sinistersix-de.009 added

by windlepoons, 8 weeks ago

Attachment: sinistersix-face.png added

Hint for face puzzle

comment:4 by windlepoons, 8 weeks ago

I compiled the master branch and now it loads correctly after *this* puzzle, other puzzles do not.

I attached another save games.

comment:5 by neuromancer, 8 weeks ago

Great, please test https://github.com/scummvm/scummvm/commit/48e32b28b7403336f99d55e85b3be9352411865f

That should fix the loading for other puzzles. Please test if you can :)

by windlepoons, 8 weeks ago

Attachment: sinistersix-de.021 added

by windlepoons, 8 weeks ago

Attachment: sinistersix-de.020 added

in reply to:  5 comment:6 by windlepoons, 8 weeks ago

Replying to neuromancer:

Great, please test https://github.com/scummvm/scummvm/commit/48e32b28b7403336f99d55e85b3be9352411865f

That should fix the loading for other puzzles. Please test if you can :)

The bank puzzle works, but not the roof puzzle (attached). I hope I don't have to test all the puzzles.

comment:7 by neuromancer, 8 weeks ago

Thanks for the testing so far. No need to test every puzzle, most of the puzzles are implemented as "scenes" from game data. These only allow to save when a scene is complete, that is why the roof puzzle cannot be saved in the middle, until the segment is complete (I think it is after you get the video from Chip's office.

The issue here are hardcoded puzzles, which we needed to re-done like the color code, the SP panel and the bank matrix one.

comment:8 by neuromancer, 8 weeks ago

This was ported to the 2.6 branch. If you have time, please test https://github.com/scummvm/scummvm/commit/363cfcce07b21cc9aea2a071431976756987b7ce so we can close the issue.

Note: See TracTickets for help on using tickets.