COMMON: Partially downloaded icon sets cannot be redownloaded

[Thunderforge]

When downloading an icon set, if the download fails halfway through, ScummVM treats the icon set as though it were fully downloaded and does not provide an option to redownload.

Reproduction Steps

1. In the Launcher, click "Global Options..."
2. Click the "Paths" tab
3. Confirm that "Icons Path" is set to an empty folder
4. Click the "Misc" tab
5. Click "Update Icons"
   • The dialog will say that two downloads are available
6. Click "Download"
7. Before the download completes, click "Cancel Download"
8. Click "Update Icons"
   • The dialog will say that only one download is available
9. Click "Download"
10. Before the download completes, click "Cancel Download"
11. Click "Update Icons"
    • The dialog will say that there are no downloads available

Additionally, there is no way to force a redownload. The only remedy is to manually go into the folder and delete the .dat files.

Possible Solutions

Probably the simplest way to verify that a complete icon set was download would be to provide a hash code and then have the Launcher validate against it. If it doesn't match, then redownload the file.

Additional Info

The log file does not provide any information at all about the download being canceled.

Versions Tested

• ScummVM 2.6.0 pre-release 2022-06-10
• ScummVM 2.7.0 daily 2022-06-10
• macOS 12.4
• Windows 11 22H1

[sev-]

Fixed