Opened 12 months ago
Closed 12 months ago
#13563 closed defect (duplicate)
COMMON: "No icons path set" error despite icons path being set
Reported by: | Thunderforge | Owned by: | antoniou79 |
---|---|---|---|
Priority: | high | Component: | Common |
Version: | Keywords: | ||
Cc: | Game: |
Description (last modified by )
With the 2.6.0 pre-release build, it is impossible to download icons due to "No icons path set" error, even if the icons path is set.
This has been tested on both macOS and Windows.
Reproduction Steps
- In the Launcher, click "Global Options..."
- Click the "Paths" tab
- Under "Icons Path", select a path
- If it matters, I chose an empty folder
- Click "Apply"
- Click the "Misc" tab
- Click "Update Icons"
The result will be the error message "No icons path set".
Additional Info
The log file does not provide any information at all.
See attached animated gif demonstrating this behavior.
Versions Tested
- ScummVM 2.6.0 pre-release 2022-06-10
- macOS 12.4
- Windows 11 22H1
Attachments (1)
Change History (6)
by , 12 months ago
Attachment: | No Icon Path.gif added |
---|
comment:1 by , 12 months ago
Description: | modified (diff) |
---|
comment:2 by , 12 months ago
Description: | modified (diff) |
---|---|
Summary: | COMMON: "No icons path set" error on Windows despite icons path being set → COMMON: "No icons path set" error despite icons path being set |
comment:3 by , 12 months ago
comment:4 by , 12 months ago
This seems to be a duplicate of https://bugs.scummvm.org/ticket/13556
The PR with the fix was merged a few hours ago, and it is now backported to branch-2-6
Please check if the issue persists.
comment:5 by , 12 months ago
Owner: | set to |
---|---|
Resolution: | → duplicate |
Status: | new → closed |
Confirmed that this is now fixed.
Looking into the code a bit, I think the problem is that the GUI dialog sets
iconpath
(singular) and the downloader getsiconspath
(plural).We should pick one or the other and stick to it throughout the codebase.