Opened 4 months ago

Closed 4 months ago

#13531 closed defect (fixed)

GUI: Updating SoundFont via GUI doesn't save changes

Reported by: Purduecoz Owned by: criezy
Priority: high Component: GUI
Version: Keywords: soundfont global options
Cc: Game:

Description (last modified by Purduecoz)

Changes to the Global Options, MIDI, SoundFont setting through the GUI in the MacOS or iOS port (2.6.0git, compiled May 29, 2022) are not saved to the Preferences file. Selecting a SoundFont shows the selection only until Apply and OK are clicked.

Once you return to the Global Options menu, the old setting is reflected. I was able to get my change to stick by manually editing the config file with the desired setting. Other Global Options config changes seem to be saving properly.

EDIT: This issue seems to be present in the Windows 64-bit daily build too.

This issue is not present in the iOS port of the released version of 2.5.1.

Change History (8)

comment:1 by Purduecoz, 4 months ago

Description: modified (diff)

comment:2 by Purduecoz, 4 months ago

Component: Port: iOSPort: Mac OS X
Description: modified (diff)
Keywords: ios removed
Summary: Updating SoundFont via GUI doesn't save changes in iOS portUpdating SoundFont via GUI doesn't save changes in MacOS or iOS Port

comment:3 by Purduecoz, 4 months ago

Summary: Updating SoundFont via GUI doesn't save changes in MacOS or iOS PortMACOS: Updating SoundFont via GUI doesn't save changes in MacOS or iOS Port

comment:4 by sev-, 4 months ago

Priority: normalhigh

Would be nice to fix before the release

comment:5 by Purduecoz, 4 months ago

Description: modified (diff)

comment:6 by criezy, 4 months ago

Component: Port: Mac OS XGUI
Summary: MACOS: Updating SoundFont via GUI doesn't save changes in MacOS or iOS PortGUI: Updating SoundFont via GUI doesn't save changes

comment:7 by criezy, 4 months ago

Thank you for the report.
I did a bisection, and this is a very recent regression from commit 7dd0c1ddf8

7dd0c1ddf87deb01628445e2457211db10616021 is the first bad commit
commit 7dd0c1ddf87deb01628445e2457211db10616021
Author: grisenti <emanuele@grisenti.net>
Date:   Mon May 16 00:56:16 2022 +0200

    ALL: add support for --midi-gain and --soundfont

 base/commandLine.cpp |  7 ++++++-
 gui/options.cpp      | 25 +++++++++++++++++++------
 2 files changed, 25 insertions(+), 7 deletions(-)

comment:8 by criezy, 4 months ago

Owner: set to criezy
Resolution: fixed
Status: newclosed

And this is now fixed.

Note: See TracTickets for help on using tickets.