GUI: Launcher loses the selected game in a filtered games list after game options

[antoniou79]

This is with ScummVM 2.6.0git, today's build from a local checkout of master HEAD on Windows 10 Pro x64.

Steps to reproduce:

• On the ScummVM launcher, either in the list view or the new grid view
• Filter the added games by a name substring
• Then select a game from the filtered results and click on "Game Options". In Grid view this is equal to clicking on a game icon and the selecting the gear icon from the small popup dialogue.
• [Optionally] edit some game settings
• Click Ok

Result:
In LIST VIEW the selected game is no longer highlighted and the option to "Start" is now grayed out.
In GRID VIEW, the filter is also no longer applied and the wrong game is now highlighted. The filter string is still in the search field, but it's not applied.

An additional issue, that might be connected, is that when in Grid View in the filtered list I select the first game result and repeat the above steps, then after clicking OK from the game options, if I click to switch to List View, ScummVM will crash with assertion fault:
Assertion failed: idx < _size, file ./common/array.h, line 232"

Note, I have quite a lot added games in my ScummVM installation. Certainly enough for the list have to be scrolled for a while to see the whole thing. I am unsure if this is related to the issue -- that is, whether the issue won't occur for small lists of added games.

[antoniou79]

Added info on a possibly connected assertion fault crash, when clicking to switch back to list view from the grid view, after doing the above steps (happens only with specific game's selected from the filtered list, not for all).

[lephilousophe]

Created PR ​#3960 which fixes it.

[sev-]

Fixed.