BACKENDS: MACOSX - alt-enter fullscreen isn't notch-aware.

[somaen]

Currently there are two distinct types of fullscreen available in ScummVM on macOS:

• Pressing the green button on the window
• This has notch-aware behavior and supports Spaces
• Pressing alt-enter
• This is NOT notch-aware for 3D games, unless we've set the "Scale to fit below notch flag" in Get Info in Finder.

Both modes seem to be notch-aware for 2D games.

Now in theory NSPrefersDisplaySafeAreaCompatibilityMode in the Info.plist should yield the same result as setting the Get Info flag, but from my testing it doesn't seem to work. And since this only affects the 3D games, I would assume there's some detail in that graphics backend that isn't doing the same thing window-handling wise as for 2D.

ScummVM 2.5.1 on macOS Monterey 12.3

[criezy]

And since this only affects the 3D games, I would assume there's some detail in that graphics backend that isn't doing the same thing window-handling wise as for 2D.

My guess is that this is related to the 3D graphics backend code using SDL_WINDOW_FULLSCREEN while the 2D one uses SDL_WINDOW_FULLSCREEN_DESKTOP to create the window.
Compare
​https://github.com/scummvm/scummvm/blob/8ea587517e/backends/graphics3d/openglsdl/openglsdl-graphics3d.cpp#L488-L501
to
​https://github.com/scummvm/scummvm/blob/8ea587517e/backends/graphics/openglsdl/openglsdl-graphics.cpp#L504-L521

[lephilousophe]

This got fixed with the 3D backend removal.