"Trim FM-Towns games to 200 pixels height" option doesn't appear in Loom FM-Towns

[LukasThyWalls]

The option "Trim FM-Towns games to 200 pixels height" in Game tab for FM-Towns games doesn't appear in all of them Loom FM-Towns.

I have installed Zak FM-Towns (Directly from GOG version) with and without a Spanish fan patch, and the only version with that option is the one with the Spanish fan translation, not the one with the vanilla files from the GOG version.
Also i tested a Loom FM-Towns with a Spanish fan translation, and also doesn't show the option.

The setting works for the one it shows it.

In ScummVM.ini file, the only games entry with the setting "trim_fmtowns_to_200_pixels" is the one that is showing it in the GUI.

[eriktorbjorn]

I can't reproduce this bug. The "Trim FM-TOWNS games to 200 pixels height" option shows up fine for me with the English GOG FM Towns version.

The only thing I can think of is if the English version was added to ScummVM so long ago that some setting in the file that it expects to be there isn't. If so, it should be visible if you re-add the game.

The conditions for when the option is added are:

• The Platform setting has to be FM-TOWNS.
• The game's detection entry has to have the GUIO_TRIM_FMTOWNS_TO_200_PIXELS flag.

The only SCUMM FM-TOWNS game I can find that doesn't have this flag is Loom.

[LukasThyWalls]

eriktorbjorn is correct.

Using 2.6.0git4526-g1d1a12b3aca, i remove and added again zak-fm in both english and spanish (fan translation) and now in both appears the setting.
Is strange because when i added them before (it's been a while) it was in a consecutive way: copying the files from GOG, copying the folder twice, applying the spanish patch to one, and adding both to ScummVM at the same time. Maybe i'm remembering wrong, but anyway, the settings appears now in both.

But it's true, the Loom FM-Towns doesn't add the option. As seen in ​https://github.com/scummvm/scummvm/blob/master/engines/scumm/detection_tables.h#L181, the detection lacks the GUIO_TRIM_FMTOWNS_TO_200_PIXELS flag.

If it's intended that flag can be used in Loom FM-Towns for any reason yet, this bug can be closed. I edited the bug to reflect the issue now it's about Loom FM-Towns only.

Thanks.

[eriktorbjorn]

I wasn't involved with implementing the feature, but from what I can see it's probably a bit harder to get Loom working correctly since. I'm attaching two EGA/FM Towns comparisons showing things that would have to be adjusted.

Might still be doable, of course.

[LukasThyWalls]

Ok, the first one (the grave headstone) is more evident that is not only to "cut" the viewscreen like in Zak-fm, so is understandable to not to do it, at least is not a straight-forward fix as i could seems in a first place.

Closing.

[ZvikaZ]

Hi.
I've implemented that feature in the other games.
Actually, I have implemented it also for Loom, but since it was more "hackish", it needed more testing.
I called for volunteers testers, but we had some "communications latency problems", which got the work to be stuck.

All of this is described at ​https://forums.scummvm.org/viewtopic.php?t=5663

I don't have time to work on it now.
If anyone wants to take my work, test it, fix the problems (if any), and send a PR, it shouldn't be too difficult...
​https://github.com/ZvikaZ/scummvm , branch: z_zm_height_200_v9

(or maybe if it's easier, I'm also fine with my code used as a reference for someone coding from scratch)

[eriktorbjorn]

I played through it recently, but you probably saw my post already: ​https://forums.scummvm.org/viewtopic.php?p=96825#p96825

The three things I noticed were:

• Object names are written over the top of the object image, not the bottom like most other versions do. Not much of a problem, but it looks strange on the objects that leave an open space at the bottom.
• The tombstone text is no longer centered.
• One of the credits screens is truncated.

But I haven't looked into fixing them.

[ZvikaZ]

@eriktorbjorn thanks for testing!
Actually, I have stopped monitoring that thread. Now I saw your post (you had a typo in the link you wrote, but never mind that ;) )

Well, I personally won't have time to work on these issues in the near time.
If anyone wants to work on it, he's got my blessing.
If not, maybe I will do it sometime in the future :)

[eriktorbjorn]

Oops, I must have done some horrible copy-and-paste error with the link. It should work now, I hope.