Opened 3 years ago
Closed 3 years ago
#13343 closed defect (invalid)
GUI: Debugger md5 works only for files in the same directory as of the ScummVM executable
| Reported by: | r41k0u | Owned by: | criezy |
|---|---|---|---|
| Priority: | normal | Component: | GUI |
| Version: | Keywords: | MD5 | |
| Cc: | r41k0u | Game: |
Description
The md5 command of debugger only works on files which are in the same directory as of the ScummVM executable. When trying to enter a full path like ./LICENSES/COPYING.LUA, it shows "File not found".
Can be fixed by using FSNode instead of Path to create the stream.
Change History (3)
comment:1 by , 3 years ago
| Summary: | Debugger md5 works only for files in the same directory as of the ScummVM executable → GUI: Debugger md5 works only for files in the same directory as of the ScummVM executable |
|---|
comment:2 by , 3 years ago
comment:3 by , 3 years ago
| Owner: | set to |
|---|---|
| Resolution: | → invalid |
| Status: | new → closed |
As explained in the pull request this bug is invalid. The current code uses SearchMan to look for the file. So indeed it does not handle paths, but it does look for the file in various places, such as the game path and the extra path.
I think the main use case for the command is to check the md5 of a game file and verify that it is not corrupted, for example when encountering bugs while playing a game. And it should already work properly (and would break if using FSNode directly instead).
PR fixing this : https://github.com/scummvm/scummvm/pull/3745