Opened 20 years ago

Closed 19 years ago

Last modified 6 years ago

#1334 closed defect (wontfix)

GUI: aspect-ratio issue in launcher

Reported by: SF/logicdeluxe Owned by:
Priority: normal Component: GUI
Version: Keywords:
Cc: Game:


ScummVM 0.5.7cvs (Dec 11 2003 21:11:24) windows When changing the aspect-ratio correction in the GUI, the change doesn't take affect before ScummVM is restarted. However it should be handles the same way, it is done with the fullscreen flag. Maybe an even better way would be taking affect immediately when the button is clicked, as ScummVM still can change the screen settings in case there is a game specific flag given. Same thing for the fullscreen flag. Just like pressing the corresponding hot keys, which also take affect immediately even at the GUI.

Ticket imported from: #858639. Ticket imported from: bugs/1334.

Change History (7)

comment:1 by fingolfin, 20 years ago

I am not happy with making it take effect immediately. Besides complicating the code quite some (for the 'Cancel' button, we need to remember all previous settings and restore them to the precise original values, if we do what you ask for; right now, we simple do nothing if cancel is pressed), I don't really see the benefit of it. If you want an immediate effect, use the hotkey.

From a UI designers POV, preference dialogs either are modeless and changes in them occur instantly; or they are modal (i.e. block program execution and have OK/Cancel buttons) and change take effect once you "commit" them via the "OK" button.

If you really want this, post a feature request, don't put it as a side remark in a bug report :-)

comment:2 by sev-, 20 years ago

Is this still considered as a valid bugreport? In my opinion it could be safely closed.

comment:3 by cyxx, 19 years ago

I second _sev, this doesn't seem valid anymore.

comment:4 by sev-, 19 years ago

Status: newclosed

comment:5 by sev-, 19 years ago

For immediate effect use hotkey Ctrl+Shift+A. Closing this. Besides GUI changed considerably since that.

comment:6 by sev-, 19 years ago

Resolution: wontfix

comment:7 by digitall, 6 years ago

Component: --Unset--GUI
Note: See TracTickets for help on using tickets.