#13318 closed defect (fixed)
SQ3: version 1.018 doesn't display ScumSoft Announcements
| Reported by: | Doomlazer | Owned by: | sluicebox |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | original | |
| Cc: | Game: | Space Quest 3 |
Description (last modified by )
tested in ScummVM version 2.5.1
In SQ3 version 1.018, Script::cue was changed to check that scripts have a client.
Unfortunately, "announce" script in 702, the ScummSoft office region, doesn't have a client, so the 702.txt lines 7 and 8 are never displayed.
Attachments (2)
Change History (8)
by , 3 years ago
| Attachment: | 702Msg7.png added |
|---|
by , 3 years ago
| Attachment: | 702Msg8.png added |
|---|
comment:1 by , 3 years ago
| Summary: | SQ3 1.018 doesn't display ScummSoft Announcements → SQ3: version 1.018 doesn't display ScummSoft Announcements |
|---|
comment:2 by , 3 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 3 years ago
| Description: | modified (diff) |
|---|
comment:4 by , 3 years ago
| Component: | --Unset-- → Engine: SCI |
|---|---|
| Keywords: | original added; 1.018 removed |
comment:5 by , 3 years ago
| Summary: | SQ3: version 1.018 doesn't display ScummSoft Announcements → SQ3: version 1.018 doesn't display ScumSoft Announcements |
|---|
just gonna... go ahead and fix that title for you... =)
comment:6 by , 3 years ago
| Owner: | set to |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Fixed in https://github.com/scummvm/scummvm/commit/cd1639019874e2c8e8ad209aa2cfb9f26c0076f3
Thanks for reporting!
Also, this script patch doesn't fix saved games where you've a already entered the office. Those saves are already tainted and the messages probably won't ever appear, at least not for a few years. So don't use those to test or you'll have a long wait! =)
Note:
See TracTickets
for help on using tickets.
Great catch! I agree with your findings, this is an unintentional regression from upgrading to a newer version of the Script class. This affects all subsequent versions, so the localized ones too.
The announcement messages only randomly happen twice per game, at most, which explains why their disappearance didn't get noticed. I don't see why we shouldn't fix this and restore the corporate ambiance. I'll do it after the SQ3 thing I'm working on now.