Opened 8 months ago

Closed 7 days ago

#13283 closed defect (fixed)

KYRA: Legend of Kyrandia (CD/DOS/English) also matches (Demo/DOS/English)

Reported by: i30817 Owned by: athrxx
Priority: normal Component: Engine: Kyra
Version: Keywords: detection
Cc: Game: Kyrandia 1

Description (last modified by i30817)

I feel like this could be a scanner bug or it could be intentional if the implementation of a 'demo' ends up in the executable and all the data is the same. I haven't had time to play through the 'demo'.

[kyra1-cd]
platform=pc
gameid=kyra1
description=The Legend of Kyrandia (CD/DOS/English)
language=en
extra=CD
path=/media/i3/Mordred/Games/ScummVM/legend_of_kyrandia_1
engineid=kyra
guioptions=midiPCSpk midiAdLib midiMt32 vga lang_English

[kyra1-demo-cd]
platform=pc
gameid=kyra1
description=The Legend of Kyrandia (Demo/CD/DOS/English)
language=en
extra=Demo/CD
path=/media/i3/Mordred/Games/ScummVM/legend_of_kyrandia_1
engineid=kyra
guioptions=midiPCSpk midiAdLib midiMt32 vga lang_English

Change History (17)

comment:1 by i30817, 8 months ago

Keywords: Launcher added

comment:2 by i30817, 8 months ago

Description: modified (diff)

Turns out i hadn't yet configured the extra path, i forgot about it.

comment:3 by athrxx, 8 months ago

Thanks for your report. I don't quite understand your last comment. Is the bug report still valid?

comment:4 by i30817, 8 months ago

Yes, but i had a additional comment about 'not finding the kyra.dat file'. That was bogus and edited out.

Last edited 8 months ago by i30817 (previous) (diff)

comment:5 by i30817, 8 months ago

Summary: Legend of Kyrandia (CD/DOS/English) also adds (Demo/DOS/English)Legend of Kyrandia (CD/DOS/English) also adds (Demo/DOS/English) in mass add

comment:6 by digitall, 5 months ago

Component: --Unset--Engine: Kyra
Game: Kyrandia 1
Keywords: detection added; Launcher removed
Summary: Legend of Kyrandia (CD/DOS/English) also adds (Demo/DOS/English) in mass addKYRA: Legend of Kyrandia (CD/DOS/English) also adds (Demo/DOS/English) in mass add

comment:7 by athrxx, 3 weeks ago

Could you please check whether you find this particular bug still valid? There have been improvements on the mass add function, but I am not sure if they address this one.

comment:8 by i30817, 8 days ago

This one still shows the demo, unlike the lands of lore cd.

comment:9 by i30817, 8 days ago

I think it's a bit weird the game and the 'demo' being on the same cd, but i guess it's possible it's just a property of the engine where all the data of the demo is in the game and it chose depending on the executable... which is not there, because i deleted unneeded files. It's not a big deal in this game i guess.

comment:10 by digitall, 8 days ago

athrxx: Close this as WONTFIX? Or does this need a patch to KYRA detection?

comment:11 by digitall, 8 days ago

Owner: set to athrxx
Resolution: fixed
Status: newpending

comment:12 by athrxx, 8 days ago

I would assume that it requires further fixing of the mass add function.
Unless it also detects the demo when adding the game "normally". Then it would probably be something that can be fixed in the Kyra detection.

comment:13 by tag2015, 7 days ago

The culprit here is the actual kyra detection, not the mass add.
There is an entry called "Special Kyrandia 1 CD demo" that uses the file INTRO.VRM for detection which is also present on the full cd release. That's why scummvm finds two entries (and it happens also with the standard add, I tested the GOG release).

We could add an additional file for detection, but unfortunately I have no idea where to find this demo.

comment:14 by tag2015, 7 days ago

Resolution: fixed
Status: pendingnew
Summary: KYRA: Legend of Kyrandia (CD/DOS/English) also adds (Demo/DOS/English) in mass addKYRA: Legend of Kyrandia (CD/DOS/English) also matches (Demo/DOS/English)

Changing title and reopening

comment:15 by athrxx, 7 days ago

I have found the demo (on my Lands of Lore CD) and made a fix that seems to resolve the ambiguity issue with the detection.

comment:16 by tag2015, 7 days ago

Working fine with my GOG version!

Can be closed

comment:17 by athrxx, 7 days ago

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.