ULTIMA: Crusader No Regret, Crusader No Remorse, Ultima VIII are added by the Launcher twice in mass add

[i30817]

In this case, they're not being confused by different games, but they are adding the game twice, with a subdirectory 'USECODE' added as the game.

[regret]
platform=pc
gameid=regret
description=Crusader: No Regret (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_regret/USECODE
engineid=ultima
guioptions=sndNoMIDI lang_English

[regret-1]
platform=pc
gameid=regret
description=Crusader: No Regret (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_regret
engineid=ultima
guioptions=sndNoMIDI lang_English

[remorse]
platform=pc
gameid=remorse
description=Crusader: No Remorse (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_remorse/USECODE
engineid=ultima
guioptions=sndNoMIDI lang_English

[remorse-1]
platform=pc
gameid=remorse
description=Crusader: No Remorse (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_remorse
engineid=ultima
guioptions=sndNoMIDI lang_English

[antoniou79]

In another ticket you mention "Mass Add" mode.
Do these duplicate/multiple additional entries happen in that mode only?
If so, could you edit the description of all the relevant tickets to reflect that?

[i30817]

Yup. I shall.

[mduggan]

As described in #13288 this happens to Ultima VIII too, combining them as it's all in the way we're using AdvancedMetaEngineDetection.

It seems if you set a value in _directoryGlobs it detects both the parent and the child directory. See UltimaMetaEngineDetection and the GAME_DESCRIPTIONS list in detection_tables.h.

For U8 and Crusader games specifically we expect the remaining files (palettes, movies, etc) to be in their correct directories, so we probably shouldn't add the entry for the USECODE directory separately anyway - it won't actually work.