Opened 8 months ago

Last modified 4 months ago

#13281 new defect

ULTIMA: Crusader No Regret, Crusader No Remorse, Ultima VIII are added by the Launcher twice in mass add

Reported by: i30817 Owned by:
Priority: normal Component: Engine: Ultima
Version: Keywords: detection
Cc: Game: Crusader: No Regret

Description

In this case, they're not being confused by different games, but they are adding the game twice, with a subdirectory 'USECODE' added as the game.

[regret]
platform=pc
gameid=regret
description=Crusader: No Regret (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_regret/USECODE
engineid=ultima
guioptions=sndNoMIDI lang_English

[regret-1]
platform=pc
gameid=regret
description=Crusader: No Regret (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_regret
engineid=ultima
guioptions=sndNoMIDI lang_English

[remorse]
platform=pc
gameid=remorse
description=Crusader: No Remorse (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_remorse/USECODE
engineid=ultima
guioptions=sndNoMIDI lang_English

[remorse-1]
platform=pc
gameid=remorse
description=Crusader: No Remorse (DOS/English)
language=en
path=/media/i3/Mordred/Games/ScummVM/crusader_no_remorse
engineid=ultima
guioptions=sndNoMIDI lang_English

Change History (5)

comment:1 by antoniou79, 8 months ago

In another ticket you mention "Mass Add" mode.
Do these duplicate/multiple additional entries happen in that mode only?
If so, could you edit the description of all the relevant tickets to reflect that?

comment:2 by i30817, 8 months ago

Yup. I shall.

comment:3 by i30817, 8 months ago

Summary: Crusader No Regret and Crusader No Remorse are being added by the Launcher twice.Crusader No Regret and Crusader No Remorse are being added by the Launcher twice in mass add.

comment:4 by digitall, 5 months ago

Component: --Unset--Engine: Ultima
Game: Crusader: No Regret
Keywords: detection added; Launcher removed
Summary: Crusader No Regret and Crusader No Remorse are being added by the Launcher twice in mass add.ULTIMA: Crusader No Regret and Crusader No Remorse are being added by the Launcher twice in mass add.

comment:5 by mduggan, 4 months ago

Summary: ULTIMA: Crusader No Regret and Crusader No Remorse are being added by the Launcher twice in mass add.ULTIMA: Crusader No Regret, Crusader No Remorse, Ultima VIII are added by the Launcher twice in mass add

As described in #13288 this happens to Ultima VIII too, combining them as it's all in the way we're using AdvancedMetaEngineDetection.

It seems if you set a value in _directoryGlobs it detects both the parent and the child directory. See UltimaMetaEngineDetection and the GAME_DESCRIPTIONS list in detection_tables.h.

For U8 and Crusader games specifically we expect the remaining files (palettes, movies, etc) to be in their correct directories, so we probably shouldn't add the entry for the USECODE directory separately anyway - it won't actually work.

Note: See TracTickets for help on using tickets.