SCI: SQ3: Sound 35 access violation

[Purduecoz]

Right at the beginning in the garbage scow, when you get into the rail grabber, it is possible to spend too much time on the initial screen where you get into the grabber. The robot on the screen walks down and will kill you. When this happens, Scummvm crashes with an error:

ERROR: Access violation reading sound.35: 14 + 2 > 0 (abs: 269 + 2 > 255)!

I've been able to reproduce it each time. The game reports that it is version 1.0U with a release date of 4/13/89. I'm using the English version of the game and the released version of Win64 ScummVM 2.5.1 on Windows 11. This is the first time I've gotten killed this way in SQ3 in a long time, so I cannot confirm if this issue existed in previous versions of ScummVM.

EDIT: This crash does not occur with v1.018 of SQ3, which is what is available via GOG.

Glad to provide any additional info that may be needed. Thanks.

[sluicebox]

Thanks for reporting this!

Confirmed that sound 35 crashes on these versions:

• PC 1.0P, 1.0U, and 1.0V
• Atari ST 1.0Q

SCI Companion also reports an error on sound 35.
The original in DOSBox makes the same sound in the broken and working versions without problems (Soundblaster/Adlib enabled)
SCI Viewer seems to handle sound 35 without problems.
Amiga 1.0V works, but it's a completely different sound.

To quickly reproduce:

• Start a new game
• room 13 in the debugger
• walk over to the grabber and climb down
• move to the robot and wait for it to blast

[sluicebox]

Fixed in: ​https://github.com/scummvm/scummvm/commit/544ccafa725ba7926430071509536563f15574e7

This will appear in the next daily build.

Sound 35 is corrupt; it has the digital sample flag set but then doesn't contain any digital sample data. Sierra fixed this in later versions by clearing the flag. We now detect this and log a warning and ignore the invalid flag. Thank you again for reporting this!