BURIED: Arthur still visible after being lost from Biochip Inventory

[jamie-marchant]

Steps to reproduce:

1. Get the Environ Cartridge from the CHICHEN ITZA underground.
2. Insert it in the system in Gage's apartment. (with the lens off).
3. Turn on the lens
4. After the cutscene(you can skip it), save.
5. Select Arthur.(with Control + A)
6. When prompted type "Gravball" without looking at the files biochip.
7. Arthur reminds visible onscreen, even though the chip is now blank. (see the screenshot)

[jamie-marchant]

Changing to another biochip(even blank) makes him disappear.

[digitall]

jamie-marchant: Please can you attach a savegame with the Environ Cartridge in Gage's Apartment and the Lens prior to the Cutscene so the BURIED engine developers can investigate this? Thanks.

[jamie-marchant]

Ok, thankfully I kept a backup before leaving. The save game should be called "Jamie". I've also slightly modified my steps to reproduce.

[digitall]

Yes, I can now replicate the issue from your savegame.

[digitall]

Fix applied as commit ​https://github.com/scummvm/scummvm/commit/7bb707e986bece461aae26b43debaa5fc9bbc3cf.

jamie-marchant: Please test and confirm with the next nightly build which will include
this fix: ​https://buildbot.scummvm.org/#/dailybuilds

[jamie-marchant]

Buildbot does not have Fedora Core builds and it took 30 minutes to compile a daily build the first time. I don't have time for this tonight. (not sure if Make has a cache)

Before I test it, I can see looking at the source code, your fix will fix my issue but cause a "strange issue" for most users. You see, I have played the game a bunch of times before and memorized the correct password to enter(so I selected Arthur to see him disappear), most players will have the "files" Biochip active to find the password. Your new source code will set it to a blank(for no good reason) when they give the correct code. The correct solution is an if statement to see if Arthur is active and change it to blank if it is.

[bluegr]

Thanks for the fix digitall, and thanks for the report and additional comments jamie-marchant!

An improved version of this fix that also checks if Arthur was selected before sacrificing himself has been done in commit 74f2df71c30f4f1e0bb9419bedb8b6b222708212:
​https://github.com/scummvm/scummvm/commit/74f2df71c30f4f1e0bb9419bedb8b6b222708212

Closing

[jamie-marchant]

Is the change here: ​https://github.com/scummvm/scummvm yet? If so, I noticed new bug as a result of this change. With this change, if your on the files Biochip, now suddenly the blank chip is selected(rather then the files one). I've attached a screenshot.(It is Linux, just with a Windows 95 window theme).

[bluegr]

When Arthur sacrifices himself in Agent 3's lair, the steps performed are the following:

• Arthur's biochip is removed from the inventory
• The blank chip is added to the inventory
• The current inventory item is set to the currently added one (this is what happens when a new item is added)
• If Arthur's biochip was previously shown on the right, the blank chip will be shown on the right instead (that's what has been done in this fix)

Both of these issues are present in the original. In this specific scene, there is an action which occurs asynchronously (Arthur's chip being destroyed and replaced with a blank chip). While this happens, the player is free to perform any sort of action, and when Arthur finishes his speech, the scripted event occurs.

We fixed the biochip shown on the right, but it's not easy to fix the selection of the inventory item without adding workarounds for specific cases that I wouldn't want to add. The inventory is updated with the blank biochip, and if the player has the files screen open, he is supposed to see that. Opening the files screen while listening to Arthur dying is surely an edge case, and I don't see any benefit to add workarounds for changing the currently selected item in this scene with specific item combinations, because we might introduce other unwanted bugs and side effects, for no real gain.

Thus, I'm closing this bug again - we haven't introduced a regression with our changes, and we don't need to mess up with core game logic and introduce other potential bugs for no real gain.