TWINE: Doors are not working sometimes

[vvs-]

On Proxyma Island the same doors sometimes might open in different directions and become stuck. I don't know yet why.

[mgerhardy]

Do you have a screenshot and maybe a savegame for me? would help to identify the scene id and the debugging.

[mgerhardy]

Proxima island has a lot of scenes

Proxima_Island_Proxim_City = 42,
Proxima_Island_Museum = 43,
Proxima_Island_near_the_Inventors_house = 44,
Proxima_Island_upper_rune_stone = 45,
Proxima_Island_lower_rune_stone = 46,
Proxima_Island_before_the_upper_rune_stone = 47,
Proxima_Island_Forgers_house = 48,
Proxima_Island_Prison = 49,
Proxima_Island_Shop = 50,
Proxima_Island_Sewer = 51,
Proxima_Island_Grobo_house = 53,
Proxima_Island_Inventors_house = 54,

you can open the debug console and change the scene with

change_scene <id>

if you found the door, please make a screenshot.

[vvs-]

I've attached several screenshots in scenes 42 and 44 demonstrating wrong door positions. They can't fully open in that state. That happens with many doors on Proxyma Island but unfortunately I didn't figured out pattern to trigger it. It looks pretty random and they might work correct as well.

[mgerhardy]

I've entered both scenes a few times and could not reproduce it. Does it happen often for you?

There are a few fixes that needs more testing in this pull request: ​https://github.com/scummvm/scummvm/pull/3633/

I've also fixed some angle related stuff in there - maybe this already fixes the issue.
But it's impossible to say whether I've fixed it by accident without being able to reproduce it. Any more hints are welcome. Everything might help.

And thanks a lot for your reports.

[vvs-]

Using vertically moving gratings

[vvs-]

I think that I found a way to trigger this bug. It always happen to me after using vertically moving gratings, especially the one on the attached screenshot. After that some other gates and doors break and start to move vertically instead of horizontally.

[mgerhardy]

this is the proxima island prison with scene id 49

[mgerhardy]

attached savegame to reproduce it - load it, use change_scene 50 - leave the room and enter the next door.

[mgerhardy]

no, doesn't work - when loading the attached savegame the bug doesn't appear. You have to:

change_scene 49
leave the scene into the underground
toggle_freecamera and c and v to spawn next to the other lift
toggle the lift to enter scene 49 again from another entrace - now the doors are broken.
change_scene 50
pick the door at the upper left side of twinsen and open it.

[mgerhardy]

processActor.y in Animations::processActorAnimations is somehow getting wrong...

[mgerhardy]

fixed in 12a0a1cd80a90d64d933a4d73d2eddb00eac0737