Opened 10 months ago

Closed 4 months ago

#13166 closed defect (pending)

TWINE: Black and white palette

Reported by: vvs- Owned by: mgerhardy
Priority: high Component: Engine: TwinE
Version: Keywords:
Cc: Game: Little Big Adventure

Description

After obtaining quest items from Maritime museum palette remains black and white until game is restarted.

Actually, activating holomap temporarily fixed this. But after travelling to another island it becomes black and white again.

Attachments (7)

scummvm-lba-de-00059.png (195.4 KB ) - added by mgerhardy 9 months ago.
scummvm-lba-de-00058.png (195.0 KB ) - added by mgerhardy 9 months ago.
scummvm-lba-de-00057.png (164.4 KB ) - added by mgerhardy 9 months ago.
scummvm-lba-cd-00001.png (102.9 KB ) - added by vvs- 9 months ago.
In museum
scummvm-lba-cd-00002.png (316.8 KB ) - added by vvs- 9 months ago.
Outside museum
(gri=44).stp (34.7 KB ) - added by mgerhardy 4 months ago.
(gri=43).stp (45.2 KB ) - added by mgerhardy 4 months ago.

Download all attachments as: .zip

Change History (20)

comment:1 by mgerhardy, 9 months ago

Do you maybe have a screenshot and a savegame?

comment:2 by mgerhardy, 9 months ago

Priority: normalhigh

comment:3 by mgerhardy, 9 months ago

scene: Proxima_Island_Museum = 43

by mgerhardy, 9 months ago

Attachment: scummvm-lba-de-00059.png added

by mgerhardy, 9 months ago

Attachment: scummvm-lba-de-00058.png added

by mgerhardy, 9 months ago

Attachment: scummvm-lba-de-00057.png added

by vvs-, 9 months ago

Attachment: scummvm-lba-cd-00001.png added

In museum

by vvs-, 9 months ago

Attachment: scummvm-lba-cd-00002.png added

Outside museum

comment:4 by vvs-, 9 months ago

I've added screenshots demonstrating black and white palette in museum (right) and outside (wrong).

comment:5 by mgerhardy, 9 months ago

lSET_DARK_PAL and lSET_NORMAL_PAL in life script

comment:6 by mgerhardy, 9 months ago

https://github.com/scummvm/scummvm/pull/3633 got a new debug command (toggle_darkpal) to test the functionality behind the script

by mgerhardy, 4 months ago

Attachment: (gri=44).stp added

by mgerhardy, 4 months ago

Attachment: (gri=43).stp added

comment:8 by mgerhardy, 4 months ago

I can't find the execution of LM_SET_NORMAL_PAL opcode in any of the scripts of the related scenes. Only LM_SET_DARK_PAL is contained in scene 43 (see (gri=44).stp)

Last edited 4 months ago by mgerhardy (previous) (diff)

comment:9 by vvs-, 4 months ago

ChangeCube calls ClearScene which resets FlagPalettePcx, no?

comment:10 by mgerhardy, 4 months ago

From 2.21 discord:

25 years old bug: Entering controls menu and leaving removes the gray filter in the museum

comment:11 by mgerhardy, 4 months ago

FlagPalettePcx is called _engine->_screens->_useAlternatePalette in our code base. Thanks for the hint.

comment:12 by mgerhardy, 4 months ago

should be fixed in branch-2-6 with a548523c6cb31dbb1c87807f61f0fd5860b547f3 (and in master with 5c1ad5c78601b3f42e8c0e95f7fb731aaee9ceae)

comment:13 by mgerhardy, 4 months ago

Owner: set to mgerhardy
Resolution: pending
Status: newclosed
Note: See TracTickets for help on using tickets.