Opened 10 months ago

Closed 6 months ago

Last modified 3 months ago

#13106 closed defect (fixed)

GUI: Launcher - Mouse wheel not consistent in "Keymaps" tab

Reported by: raziel- Owned by: antoniou79
Priority: normal Component: GUI
Version: Keywords: launcher, mouse wheel
Cc: Game:

Description

ScummVM 2.6.0git (Nov 27 2021 09:20:13)
Features compiled in: TAINTED Vorbis FLAC MP3 RGB zLib MPEG2 Theora AAC A/52 FreeType2 FriBiDi JPEG PNG GIF cloud (servers, local) TinyGL OpenGL

The mouse wheel does not work as expected in Options/Keymaps.

If i try to use the mouse scroll wheel while inside the tab window (between the left border and the scroll bar on the right) it will only scroll either 1 pixel up or down, before it stops again (keeping the mouse pointer on the same position).

I can make it go another pixel, if i move the mouse up or down (but funnily enough, not right or left), but it looks kind of random as to when it actually scrolls.

Something i found is, that when the mouse is lined up with the buttons on the left, it will *never* scroll, if i line it up with the "space" between those buttons it will *always* scroll, strange.

It also scrolls perfectly fine up and down, if i keep the mouse pointer *over* the scroll bar on the right, but i'm not sure if that was the intended behaviour?

This was confirmed on a Windows32 build.

Windows32
AmigaOS44 - PPC - SDL - BE
gcc (adtools build 11.1.0) 11.1.0

Change History (6)

comment:1 by antoniou79, 6 months ago

Owner: set to antoniou79
Resolution: pending
Status: newpending

This should be fixed by the following commit:
https://github.com/scummvm/scummvm/commit/325260f1ae26c4e8954235f32c314445eb78cbb6

The PR was merged a few hours ago, so if possible can you test with the next daily developer build to confirm that the issue is resolved for you?

comment:2 by raziel-, 6 months ago

Confirmed fixed.

Thanks a lot

comment:3 by antoniou79, 6 months ago

Resolution: pendingfixed
Status: pendingclosed

in reply to:  1 ; comment:4 by alxpnv, 3 months ago

Replying to antoniou79:

This should be fixed by the following commit:
https://github.com/scummvm/scummvm/commit/325260f1ae26c4e8954235f32c314445eb78cbb6

The PR was merged a few hours ago, so if possible can you test with the next daily developer build to confirm that the issue is resolved for you?

Unfortunately, this commit introduced a regression: scrolling tabs in the "Game Options..." and
"Global Options" dialogs with the mousewheel leads to an infinite loop

...
3 0x000000d258f4ea25 in GUI::Dialog::handleMouseWheel (this=0x7f7ffffbf250, x=393, y=13, direction=1) at gui/dialog.cpp:245
4 0x000000d258f36b19 in GUI::Widget::handleMouseWheel (this=0xd48b42d200, x=393, y=13, direction=1) at ./gui/widget.h:14
5 0x000000d258f4eac6 in GUI::Dialog::handleMouseWheel (this=0x7f7ffffbf250, x=393, y=13, direction=1) at gui/dialog.cpp:249
6 0x000000d258f36b19 in GUI::Widget::handleMouseWheel (this=0xd48b42d200, x=393, y=13, direction=1) at ./gui/widget.h:141
...

in reply to:  4 ; comment:5 by antoniou79, 3 months ago

Replying to alxpnv:

Unfortunately, this commit introduced a regression: scrolling tabs in the "Game Options..." and
"Global Options" dialogs with the mousewheel leads to an infinite loop

Can you check that the commit I've pushed fixed this?
https://github.com/scummvm/scummvm/commit/dc69bd4d67292db883f7b98d80d528df53a6f8f3

in reply to:  5 comment:6 by alxpnv, 3 months ago

Replying to antoniou79:

Can you check that the commit I've pushed fixed this?
https://github.com/scummvm/scummvm/commit/dc69bd4d67292db883f7b98d80d528df53a6f8f3

Works great. Thank you!

Note: See TracTickets for help on using tickets.