GUI: Wrong list items are disabled in the SCUMM launcher

[eriktorbjorn]

If a game has been added to ScummVM and the directory for it no longer exists, it's supposed to be grayed out in the ScummVM launcher.

However, the colour and the list entry are apparently kept in different data structures, and now group headers apparently throw off the numbering of the entries.

E.g. I had moved a game to a different directory. ScummVM grayed out the game that was listed above it, presumably because of some (invisible?) main header.

If I changed the grouping so that it added a multitude of headers, the grayed out line was way out of place.

Also, applying a search filter seems to remove the graying completely?

In the attached screenshots, only "[LucasArts] Maniac Mansion (GOG Broken Version)" is supposed to be grayed out.

(Don't mind that the search box looks ugly. I usually run with a 4x scaler, where I can safely use large text. I changed to 2x to keep down the size of the screenshots, and didn't bother to make the text smaller.)

[digitall]

Responsible code for this behaviour is in gui/launcher.cpp line 1052 to 1070:
​https://github.com/scummvm/scummvm/blob/master/gui/launcher.cpp#L1052

[sev-]

Fixed. Please test comprehensively :D

[sluicebox]

Possibly related: #13525

All of my disabled games are now highlighting correctly, thanks! That's been confusing me at least once a week since it was introduced.

[sluicebox]

Also possibly related: #13541