Opened 9 months ago

Last modified 7 weeks ago

#12998 new defect

AGS: Quest for Glory II: Trial by Fire Remake - Toolbar icons often glitch on click

Reported by: Thelypody Owned by:
Priority: normal Component: Engine: AGS
Version: Keywords:
Cc: OmerMor, Smelltastic Game: Quest for Glory 2

Description (last modified by Thelypody)

Quest for Glory II: Trial by Fire Remake features a top toolbar similar to Sierra's VGA games in the series. Clicking on any of the left five buttons often produces a bug where the toolbar just disappears for a split second instead of registering a click and switching cursor action. This is extremely annoying in case of the fifth button, Special Actions, as instead of opening an additional menu it just moves the cursor closer to the middle of the screen where it expects a new button row to appear. Interestingly this does not affect the right five buttons starting from the sixth Magic button.

Steps to reproduce:
1) Create a new character and start a game
2) Click on any of the top left five buttons

ScummVM 2.5.0
Windows 10 20H2 64-bit

Change History (17)

comment:1 by Thelypody, 9 months ago

Upon further examination, the same issue also happens in all AGDI's King's Quest remakes.

comment:2 by Thelypody, 9 months ago

Description: modified (diff)

comment:3 by danaith1234, 8 months ago

I have the exact same issue. sometimes i get lucky and it actually appears. otherwise it glitches. almost seems like it wants to pull up but just doesnt, maybe a speed issue, it seems to quick to catch the bar

comment:4 by danaith1234, 8 months ago

i have found an odd "workaround" if you click on the special action bar, then quickly move your mouse down(and i mean quickly) itll catch the pop up menu. it still doesnt work everytime but i can get it down to ALMOST work every time

comment:5 by OmerMor, 8 months ago

Cc: OmerMor added

comment:6 by Smelltastic, 6 months ago

I came into these forums to post a bug with the QfG2 VGA remake that the Special Action button, to bring up the walk/run/sneak/status etc page, wouldn't open. I believe it's this same issue. When I swipe down quickly while pressing the button I can get it to come up, like OmerMor posted (thank you!).

What's weird is that for me, all the other buttons seem to work fine, including the magic, inventory, and system menus. Only that one button consistently has the issue for me.

comment:7 by Smelltastic, 5 months ago

Cc: Smelltastic added

comment:8 by bliznik, 4 months ago

Thanks for opening this ticket. Also, thanks for the workaround! On a related note, you don't need to "quickly" move your mouse, you can simply left-click and drag your mouse pointer down to where the Special Action menu should pop up. If you release your left-click in the correct area (to overlap with the special menu), then you can access the menu.

I am guessing that, when you click on the icon, the game pulls up the special menu. If your mouse location overlaps with the special menu, the special menu will stay on the screen. But if your mouse location does not overlap with the special menu, the game closes the special menu.

In the original AGD Interactive version, after the game activates the special menu, it relocates your mouse location to a location over the special menu. In ScummVM, after the game activates the special menu, your mouse location does not move. So, the game will automatically close the special menu immediately after opening it since it detects that your mouse pointer location does not overlap with the special menu. In order to fix this bug, a programmer will probably need to create a special instruction just for games like this one, which will relocate the mouse pointer location to a location that overlaps with the special menu upon activation of the special menu.

Last edited 4 months ago by bliznik (previous) (diff)

comment:9 by lwcorp, 3 months ago

Game: Quest for Glory 2

comment:10 by i30817, 3 months ago

It's probably better to open this in upstream if it happens there, since that dev is more active.

Upstream is at: https://github.com/adventuregamestudio/ags/issues

in reply to:  10 comment:11 by bliznik, 3 months ago

Replying to i30817:

It's probably better to open this in upstream if it happens there, since that dev is more active.

Upstream is at: https://github.com/adventuregamestudio/ags/issues

Huh? Does Upstream fix bugs that occur only in ScummVM and not anywhere else? This is an issue that only occurs when you play the game using ScummVM. This issue doesn't occur if you play the game using the normal executable.

comment:12 by i30817, 3 months ago

I just tested current ags with the game and you're right. I just suggested because ags often has regressions.

But i found other problems to report in this game there so, i'm going to do that now.

comment:13 by i30817, 3 months ago

BTW i also tested in a self compiled scummvm executable (not libretro or any other port) and it had no such problem here so i don't know what's happening.

comment:14 by i30817, 3 months ago

Ok i just tested the libretro scummvm core (updated version based on upstream master here: https://github.com/diablodiab/libretro-scummvm-backend with one of the patches in the bug report page there to make mouse cursor work on some other games) and i noticed the problem reported here so i'm testing if i can reproduce after pulling the latest scummvm code and testing with that backend again.

Last edited 3 months ago by i30817 (previous) (diff)

comment:15 by i30817, 3 months ago

Yup, happens there for some reason. Although it happens 'once' (the main cursor doesn't appear to change - although if you move out of the bar it does - and the bar flashes once) and then if you click a second time it works 'correctly' (the main cursor changes even on top of the bar, the bar doesn't flash), then it repeats.

Note that in scummvm the bar actually disappears completely the first time. I think the 'problem' here is that the bar was supposed to disappear to show the icon (moving the cursor down if it was in the original bar hotspot) but it only happens the second time. The skill button doesn't even do anything if you're not 'above the area the cursor would be moved to.

It's kind of weird this is happens to me only on the libretro core - especially this version which is using upstream code instead of being thousands of commits behind.

Last edited 3 months ago by i30817 (previous) (diff)

comment:16 by i30817, 3 months ago

I opened bugs for this in

ags (this is also about broken buttons i noticed): https://github.com/adventuregamestudio/ags/issues/1610

and in the scummvm backend core: https://github.com/diablodiab/libretro-scummvm-backend/issues/7

Just to keep track if it's fixed in one of these places.

comment:17 by i30817, 7 weeks ago

BTW, this engine shows another bug in heroine's quest (in scummvm not in upstream ags) where thrivaldi portrait appears midway through the intro as if it was 'speaking' after thrivaldi does a fist shaking animation. This doesn't happen (anymore i guess) in upstream ags. I'll open a bug for it.

Last edited 7 weeks ago by i30817 (previous) (diff)
Note: See TracTickets for help on using tickets.