Opened 2 years ago

Closed 2 years ago

#12977 closed defect (fixed)

Engines: Incorrect MetaEngine::getSavegameFile implementations

Reported by: criezy Owned by: orgads
Priority: normal Component: Common
Version: Keywords:
Cc: Game:


The default MetaEngine::getSavegameFile one of two schemes:

  • target.#### if kSavesUseExtendedFormat is supported
  • target.s## otherwise

Yet many engines do not support kSavesUseExtendedFormat and do not reimplement getSavegameFile, but are still using the first scheme.

For example with the lure engine, getSavegameFile(1, "lure") returns lure.s01, but the name actually used by the engine is lure.001.

As a result functions using getSavegameFile(), such as copySaveFileToFreeSlot() fail.

Having a correct implementation for all engines would also allow to simplify some code, such as removeSaveState() which would no longer need to be reimplemented in many engines.

Change History (2)

comment:1 by orgads, 2 years ago

Component: --Unset--Common
Owner: set to orgads
Resolution: pending
Status: newpending

comment:2 by orgads, 2 years ago

Resolution: pendingfixed
Status: pendingclosed
Note: See TracTickets for help on using tickets.