AGS: 7 Days A Skeptic - Audio volume issues

[antoniou79]

This is tested on Windows 10 x64, daily development build (ScummVM 2.4.0git186-g592f8b42c8 (Sep 8 2021 05:56:07)) and a local build (Windows, msys2, latest checkout from master).

Here are the issues I've noticed:

• The in-game sound volume controls which show up when putting the mouse cursor at the top of the screen do not seem to affect sound. There are two volume controls there, labelled "music" and "sound", and none of them affects sound (steps, ambient sound). However, I was not able to test them affecting music volume, since during intro when music is played, this in-game panel is not available.
• Setting the volume from the in-game controls is also not synched with any of ScummVM's own GMM sound options.
• Setting volume from the GMM, affects in-game sound only when changing the SFX volume. This affects both steps sound and ambient sound. The music (playing during intro) is not affected when changing music volume from GMM. Edit: This seems to be fixed by ​https://github.com/scummvm/scummvm/commit/f9630d6981fa9747804f4cb0346950cc681b578e

[antoniou79]

Testing with a build from current master, the music volume of the midi song playing during the intro can now be affected by the ScummVM GMM Music volume control.

This seems to be a result of commit:
​https://github.com/scummvm/scummvm/commit/f9630d6981fa9747804f4cb0346950cc681b578e

The other issues still remain.

[dreammaster]

Syncing from games to ScummVM's GMM is deliberately not supported. Too many games call the same script methods the volume sliders call to, for example, reduce music and/or sfx volumes during cutscenes when speech is being played. Or tend to set the volume to "defaults" when a new game is started. In the end I had to keep them separate, and the final volume is a combination of the ScummVM GMM volume controls and the in-game volume settings.

I'll have a further look at the first point.

[dreammaster]

Huh. Seems like it could be an original game bug. I tried dragging the sliders in the standalone AGS, and not only didn't the sound volume change, but for the "Sound" slider, it didn't even trigger any calls to the method "Slider_GetValue". I then tried in the original 2004 bundled executable, and it didn't change the volume either. So I presume it's an original game bug.. something that was never implemented.

BTW: Changing the music slider did trigger Slider_GetValue, so maybe the music slider at least works, it's hard to say since none of the first few rooms had any music.