BACKENDS: WII: scummvm always returns to system menu on exit

[eku]

Since commit d40d84e scummvm always returns to system menu on exit. Unfortunately, the commit message does not state which bug it is intended to fix.

I use WiiFlow Lite to manage and launch games on the WII. All other components (homebrew, emulators, etc.) work in such a way that when they are closed, WiiFlow Lite is started again via a stub im memory.

This is quite annoying when launching ScummVM from HBC or another launcher (WiiFlow Lite). After all, that's exactly where you want to return to when ScummVM exits.

[AReim1982]

If you use ScummVM e.g. via the Homebrew Channel or the ScummVM Forwarder Channel, the screen remains black when you exit ScummVM. Returning to the main menu is the best solution in my opinion.

This ticket collides with the following fixed bug:
-> https://bugs.scummvm.org/ticket/11750

[eku]

Hello Alexander,

the provided test build already crashes on startup no matter which game the loader provied as argument. See attached foto.

[eku]

Is there anything else I can do to move the issue forward?

[AReim1982]

I've tested and debugged a lot. At the moment I cannot isolate the problem. It has nothing to do with a new version of the development environment or its dependencies. It also has nothing to do with changes to the WII port. I am still working on it, but there is currently no other solution to the problem.

[eku]

Regarding the black screen when exiting, I suspect the newlib in recent DevkitPPC.
I don't think scummvm does that even if the code is also a bit altered.

Here, it may have to do with the getcwd condition in [main.cpp|​https://github.com/scummvm/scummvm/blob/master/backends/platform/wii/main.cpp#L213] that fails to interpret wiiflow arguments... Returning to home menu is not a solution.

See Genesis-Plus-GX similar issue and possible fixes: [ekeeke/Genesis-Plus-GX#357(comment)|​https://github.com/ekeeke/Genesis-Plus-GX/issues/357#issuecomment-809811217].

[AReim1982]

@eku: You are right, apparently the problem is caused by a change to the Newlib. Can you please test the following build?
-> ​https://www.mediafire.com/file/e0zczgwmd31acuj/scummvm_rc1.tar.gz/file

[eku]

Perfect. The version starts cleanly and also returns to the loader, which is WiiFlow Lite for me. That's how it has to be.

Then my guess was right and the jump to the system menu was just a symptom correction. All's well that ends well.

Please enter a reference to the commit of the correction here so that I can check from which Nightly the correction is included.

Thank you very much.

[AReim1982]

The newer DevKitPPC versions have also exposed other problems that I have to analyze and fix. A corresponding patch may still take a while. I will compile the upcoming release of ScummVM 2.5.0 with my older development environment, as these problems do not arise there. I'll keep you updated in this ticket ...

[eku]

Hello Alexander

How are you getting on with adapting to the new version of devKitPro? Can you already give a date for the release?

[AReim1982]

We haven't found a solution yet. The problem you reported is just the tip of the iceberg. However, you can use the official ScummVM Release 2.5.0 from the project homepage.

[eku]

However, you can use the official ScummVM Release 2.5.0 from the project homepage.

No, that one returns to Wii's System Menu. That's what this issue is about.

[AReim1982]

It definitely works. Did you really use the download from the following website?
-> ​https://www.scummvm.org/downloads/

[eku]

​https://github.com/scummvm/scummvm/blob/branch-2-5-0/backends/platform/wii/main.cpp#L256

How can this work if this line is still in? It still returns to system menu and not to the loader.

[AReim1982]

Because I commented out this line for the release. I also didn't compile the release with the same environment as the Buildbot. Maybe you just try it out?

[eku]

I'm sorry, but I didn't know that. I only looked at the commits. In fact, this version 2.5 returns to the loader.

So far so good. But now I'm stuck with version 2.5. So far I have always used the daily snapshots. Are the ​instructiones still correct? Are the additional libraries described on ​compiling ScummVM included in the container?

[AReim1982]

Yes, the instructions should be correct. But only if you want to use a current version of the development environment. This will create a relatively unstable ScummVM. According to the current status, you should have a version of the DevKitPPC less than or equal to R30. You could use my DevKitPPC R28 and my old instructions:
-> ​https://forums.scummvm.org/viewtopic.php?t=13357&start=150

If you decide for the new version of DevKitPPC, then you could at least help eliminate bugs... ;-)

[eku]

Are you still working on this issue?

[eku]

Again, is someone going to fix the issue?

[AReim1982]

The problem was solved a long time ago. However, the ticket was not closed.

[eku]

It's nice to read that it is fixed.

Please be so kind and link the commit and the version including the release note, in which it is first contained. Thank you.

[AReim1982]

The problem only existed in a few official releases. Since the official version 2.5.1, an older version of devKitPro was used for compiling, in which the problem does not exist. The problem has been solved by devKitPro and since the official version 2.8.0, a newer version of devKitPro is used for compiling. The commit d40d84e was reverted by commit 233d969.