Changes between Initial Version and Version 1 of Ticket #12845


Ignore:
Timestamp:
Aug 28, 2021, 6:07:10 AM (3 years ago)
Author:
macca8
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12845 – Description

    initial v1  
    22
    33A picture speaks a thousand words (see attached).
     4
     5Refers to commit [https://github.com/scummvm/scummvm/commit/873ba580fb51ae38c9768ac04dd9202ee2bc0b09 873ba58 - Warn when enabling autosave on options if non-autosave games are stored in autosave slot].
     6The commit message and code clearly target listing only non-autosave games, however, it seems that no consideration has been made for that list to be empty, thus prompting an unnecessary warning.
     7
     8If I'm understanding this commit correctly, it also attempts to minimize the number of game engines that need to be tested, by constructing a sample size of 10 non-autosave games, rather than a complete list (but I may be mistaken). It follows that, if this list is empty (or less than 10), then testing will continue until all game engines have been tested, which may not be the desired outcome for those with a large number of games installed.