Opened 6 months ago

Closed 2 weeks ago

#12761 closed defect (fixed)

PRIVATE: Cinematics in Private Eye are too slow

Reported by: neuromancer Owned by: neuromancer
Priority: high Component: Engine: Private
Version: Keywords: PS3
Cc: neuromancer Game: Private Eye

Description

Reported in the Discord.

  • ScummVm version : 2.3.0git21099-gc2dc7c9e86 (24 July 2021)
  • Bug/issue : company logos at the start run fine , quickly after that the Introduction Cinematic are severely hatched : (video frame running slow & sound hatchered) At the main principal menu the french narrator voice is 100% fluide no problem. I select Original Story and start the game : again the cinematic are severely hatchered (video frame running slow & sound hatchered) After that , once INTO the gameplay portion : everything look to work just fine , sound is fluid. Im able to put the bottle on the desk and heard the narrator & music perfectly fine & smooth. But i experience multiple "Eject" when im playing , BAM black screen and im kicked back to the PS3 XMB (Main menu) i experienced it couples of times in 15min of gameplay....
  • Language of game : French version
  • Version of game : private-eye-win-fr-1 (windows/french) CD-ROM
  • Your OS : PS3 console CECH-2001a

Attachments (6)

IMG_8177.JPG (1.2 MB ) - added by Markamiga500 5 weeks ago.
IMG_8181.JPG (997.0 KB ) - added by Markamiga500 5 weeks ago.
IMG_8176.JPG (1.2 MB ) - added by Markamiga500 5 weeks ago.
IMG_8178.JPG (1.2 MB ) - added by Markamiga500 5 weeks ago.
IMG_8182.JPG (1.5 MB ) - added by Markamiga500 5 weeks ago.
IMG_8183.JPG (1.2 MB ) - added by Markamiga500 5 weeks ago.

Change History (68)

comment:1 by Markamiga500, 5 months ago

May I know if someone have seen this ticket ?
Im new to this and are wondering...

comment:2 by sev-, 5 months ago

Summary: Cinematics in Private Eye are too slowPRIVATE: Cinematics in Private Eye are too slow

comment:3 by sev-, 5 months ago

I pushed a potential fix. Could you please test with tomorrow's daily build?

comment:4 by Markamiga500, 5 months ago

I will do

Im so happy to read this :)

in reply to:  3 comment:5 by Markamiga500, 5 months ago

Replying to sev-:

I pushed a potential fix. Could you please test with tomorrow's daily build?

Hi Sev
I downloaded / installed the PS3 daily build 690562b1
just tried the game Private Eye with very same result

Did you have seen or received by someone on discord the short video i made showing the issue ?

I still have the video
I tried to attach it here but it say the file is too big
(its only 93.6Mb !!)

comment:6 by sev-, 5 months ago

Yes, I saw the video.

To understand whether the problem is in the decoder, could you please text "Blue's Clues: Blue's Birthday Adventure (Windows Alternative Demo)" from our website (https://downloads.scummvm.org/frs/demos/scumm/he/BluesBirthday-win-demo2-us.zip) and tell me if the actor animations (which are also Smacker videos) all smooth or choppy.

comment:7 by Markamiga500, 5 months ago

The Actor Animation are totally smoooth!

in reply to:  6 comment:8 by Markamiga500, 5 months ago

Replying to sev-:

Yes, I saw the video.

To understand whether the problem is in the decoder, could you please text "Blue's Clues: Blue's Birthday Adventure (Windows Alternative Demo)" from our website (https://downloads.scummvm.org/frs/demos/scumm/he/BluesBirthday-win-demo2-us.zip) and tell me if the actor animations (which are also Smacker videos) all smooth or choppy.

The Actor Animation are totally smoooth!

comment:9 by neuromancer, 5 months ago

I'm going to check how that is implemented. Most likely this is caused by how the Private Eye engine was implemented to force the conversion to a single palette on screen. I have some code that removes that conversion, and it works fine for videos (that will remove the slowdown), however, it breaks everything else :(

comment:10 by Markamiga500, 5 months ago

I truly hope you guys will find a fix for this gem.
Are you able to communicate with somes veteran/specialist (scummvm on PS3) ?
I heard they retired but maybe they can do some kind magic for a very last time for this classic.

fingers crossed
waiting for your news/updates guys

comment:11 by Markamiga500, 5 months ago

Any good news... ?

comment:12 by neuromancer, 4 months ago

Nothing from my side. The composing of the images in the screen, without using image conversion is still a work in progress and it won't rendering anything (beyond the videos, that look correct). On top of that, I cannot test this on a PS3 nor give you a special build. I should update the master branch with some experimental code, that could break the game for everyone, so I will wait until the release to start working on that.

comment:13 by neuromancer, 4 months ago

@sev had one idea to test some new code for the PlayStation3. We need you to try this commit: https://github.com/scummvm/scummvm/commit/df3c1d7e534d4bdcfac065b85e54f54a83625c17 (just look for the more recent build for the PS3). This recent change won't solve the issue, but at least we will know of the videos are playing fine. @Markamiga500, you will need to use the full game (the demo won't work correct) since scummvm will only properly play the intro videos (you could need to click in the screen once or twice, it will be completely black). The rest of the game won't work since the menus are not rendering correctly, but at least you should check if the speed of the videos is better or not.

Please test it and let us know if this works better. Thanks!

comment:14 by Markamiga500, 4 months ago

@Neuromancer , @Sev : Ok , I will download version 489b1a80 and check the intro cinematic speed and get back to you.

Thanks

comment:15 by Markamiga500, 4 months ago

@Neuromance , @Sev : I tried it with latest version 489b1a80 , like always the 4x company logos run well (static image) but once the cinematic intro start its still laggy.

I tested all the 3x scummvm version i dowloaded recently to test this game and i can confirm no amelioration at all in the speed/fluidity of the Cinematic Introduction.

Should I mention that I try to run/play my old (FRANCE) version (french/francais audio)... ?!

Im so sad , this is TRULY a little Gem of a game and would be a nice addition to the scummvm game box !

comment:16 by sev-, 4 months ago

No, that is not the version to test with. The commit neuromancer refers to is 9 commits later. You need to test it after tonight's build, e.g. tomorrow.

comment:17 by Markamiga500, 4 months ago

@Sev , i dont understand
its neither version 489b1a80 or de7b9cb9 ?!

I always download PS3 scummvm version here : https://buildbot.scummvm.org/#/snapshots

So if its 9 commits later , please where i can find the PS3 pkg version to test it ?
I need a website link or a gmail/google/cloud download...

Currently waiting for your reply

EDIT : I searched everywhere there :
​" https://github.com/scummvm/scummvm/commit/df3c1d7e534d4bdcfac065b85e54f54a83625c17
(just look for the more recent build for the PS3)."

I dont find any PS3 Pkg version to download...
I dont know if i need to create one , is so i really dont have a clue how doing so...

Please someone can show me a website link where i can dowload the version you want me to test in PS3 pkg format ?

I can see its df3c1d7
I searched everywhere to see a PS3 pkg format without success.
I downloaded the zipper file df3c1d7e53............
but its a lots of files and i dont know what to do with this :(

Last edited 4 months ago by Markamiga500 (previous) (diff)

comment:18 by sev-, 4 months ago

The nighly builds are built once per day, around 2 am European time. Download the build tomorrow.

comment:19 by Markamiga500, 4 months ago

@Sev , where i can find thoses "nighly builds" ?

its another description to say "Latest" that are available here
https://buildbot.scummvm.org/#/snapshots

or its a different build that i need to seek somewherelse ?
if yes , where i need to go to find thoses "nighly builds" ?

comment:20 by criezy, 4 months ago

Yes, that's the correct link for the nightly builds (it clearly says "ScummVM Buildbot nightly builds" on that page). And you will indeed need to take the "latest" build and not "stable" build on that page.

The issue was not the link, but that you need to wait until tomorrow to have one that includes the change that neuromancer made today. The build currently available on that page is from last night, so before the change was made.

comment:21 by Markamiga500, 4 months ago

Great
everything is clear now
sorry for the confusion , im a newbie with heart for retro gaming :)

Thanks for the clarifications

I will download it again tomorrow (after midnight here) and will update you quickly

comment:22 by Markamiga500, 4 months ago

@Sev , @neuromancer , @criezy

I just cannot believe it !!!
the Introduction Cinematic is extremely more smoother/fluid !!!

The 4x company logo at the start dont show up (black screen) with fluid music in the background.
then the introduction cinematic start (with a white border all around the video this time)

I compared it to this one : https://www.youtube.com/watch?v=fuV7d9Si4qo&t=478s
its not as faster to this one , but pretty close !!!

Your on the good road my friends !
I just cant believe it !!!
you guys are real codes magicians :)

comment:23 by Markamiga500, 4 months ago

I retract what i said about the speed.
i compared again with my laptop aside the television and the speed is 1:1 compared to the U.S. & France release.

:)

comment:24 by neuromancer, 4 months ago

Thanks a lot of helping with the testing. I will update you when there is more code to test in the following weeks. Eventually, the different code for the PS3 will be merged and everyone will be able to enjoy an optimized experience when playing.

comment:25 by Markamiga500, 4 months ago

@neuromancer its me that thanks you , a lot !
:)

comment:26 by neuromancer, 4 months ago

@markamiga500 please test commit https://github.com/scummvm/scummvm/commit/39782a2f37d673f5b1e765fd50af405637cf67b1 (or later) in your PS3 and let us know how playable it is. I managed to fix some colors without forcing conversions, but some palettes are still a mystery to me.

comment:27 by Markamiga500, 4 months ago

Ok I get back to you

comment:28 by Markamiga500, 4 months ago

@neuromancer The game is playable , very well to say the least.
only one minor issue , i hope its something you guys will be able to do something about it :

Everything seem to work properly from my memories when i played this game back then but if i refer to this youtube video at exactly 09min42sec , my version played on scummvm have the white cursor moving extremely slowly compared to this video :

https://www.youtube.com/watch?v=mO4lddIPgLs

Im sure its not normal

Aside this , game play/work fine and white cursor move at very good/normal speed.

Let me know if something can be done about it (white cursor slow on map on desk screen)

Last edited 4 months ago by Markamiga500 (previous) (diff)

comment:29 by Markamiga500, 4 months ago

I forgot to add the youtube link so here it is : https://www.youtube.com/watch?v=mO4lddIPgLs

comment:30 by neuromancer, 4 months ago

That's very good news. We are working to fix the issues related with color palettes that I'm sure you noticed when the videos are playing (and when you see the intro logos).

Regarding the slowdown you refer, is it happening when you click the radio or just when you enter the "desktop mode"?

comment:31 by neuromancer, 4 months ago

btw, this commit: https://github.com/scummvm/scummvm/commit/c3019f9398004f3d0e7203e9cb978a81a355fc2b introduces palette composition, which can slow down the scene transition and a little bit the videos to correct the border palette. It will be improved in the following commits, but it could be useful if you can test it anyway.

comment:32 by Markamiga500, 4 months ago

Hello Neuomancer ,

to answer your question when i tested it the last time the slowdown occured even just entering the "desktop mode"
I have yet to try with the radio
Seriously i didnt even noticed the palette composition...
to me it was looking really good!
the pace of the fluidity was enough for me to get blind about anything else i guess ;P

Ok i will give it a try in 12 hours
Thanks you so much for your help & support
Really appreciated !

comment:33 by neuromancer, 4 months ago

to answer your question when i tested it the last time the slowdown occured even just entering the "desktop mode"

I think I know the cause of this. I will check this as soon as we have a more stable code for the palette handling.

Seriously i didnt even noticed the palette composition...

I think the border was wrong and perhaps some other things. You can check some "original" screenshots here:

https://www.mobygames.com/game/private-eye/screenshots

Please let us know if there is any regression in the more recent versions. Thanks!

comment:34 by Markamiga500, 4 months ago

Ok I will test it tonight in couples of hours

comment:35 by Markamiga500, 4 months ago

BIG regression in the latest 8c25108b version.

The start up with 4x companies logo have a red screen behind them (color have issues on logos)
and when the game start it have slowdown in the introduction cinematic and screen have a red filter also...

comment:36 by Markamiga500, 4 months ago

Hi
Did you want me to take picture of the tv screen to actually show the situation or my description mean something for you guys ?

Prior to the last changes we was close getting it playable and i dont know why the last change broken the game again...

Please let me know if i can do something ? Pictures/ description anything...

comment:37 by neuromancer, 4 months ago

Hi @Markamiga500,

We already identified what the game is doing and we are working on replicating thisin scummvm. Fortunately, there is no need for screenshots or videos from your side. In the meantime, just use the old build to play the game in the PS3.

Thanks!

comment:38 by neuromancer, 3 months ago

Hi @Markamiga500, if you have some time, please test commit: https://github.com/scummvm/scummvm/commit/48bdc8f63eda5db6df82600d305e0c72a8c87ea8 in your PS3.

It should do some color remapping for the videos/border with good performance. There are some artifacts when it starts, but the rest looks fine.

Anyway, the issue in the "desktop" screen is not solved yet, but soon it should be. Thanks!

comment:39 by neuromancer, 3 months ago

Just pushed https://github.com/scummvm/scummvm/commit/a14662a5ef17fe56f7333c4bbec5090115f9fcc3 with a fix to the desktop screen issue. Please let us know if that works better in the PS3.

comment:40 by Markamiga500, 3 months ago

Hi
I just wake up
ok i will do

I just downloaded the 72bdc5ea Master Branch

comment:41 by neuromancer, 3 months ago

@Markamiga500

I'm afraid you will need to wait until the next build (tomorrow I think), 72bdc5ea is previous to the ones you need to test.

comment:42 by Markamiga500, 3 months ago

Unplayabe
i made a 1min video here showing the result : https://drive.google.com/file/d/1xabBOzwdi4YUn7BHjbhq-tkaz1Ee2gBs/view?usp=sharing

its getting worst and worst compared to this version where EVERYTHING look to run flawlessly (aside the desk city map section where the cursor is sooo slow) : https://github.com/scummvm/scummvm/commit/39782a2f37d673f5b1e765fd50af405637cf67b1

After this release i got red filter screen and extremely laggy

Mark

comment:43 by neuromancer, 3 months ago

Can you confirm which version you tried? Is it 7b2150a? Also we can't access the video. Can you try to upload it to https://wetransfer.com/ ?

Thanks!

comment:44 by Markamiga500, 3 months ago

Hi Neuromancer ,
I downloaded tonight (after midnight) 02th November 2021 this version : ps3-master-fcca692e

its weird
the intro with company logo still have the red filter but are now INVERTED.
after that the game cinematic intro color is right and very good original speed (smooth & fast without any video lags/skipping frame) everything is fine in the cinematic intro

right after that at the Principal Menu have a red tint filter over the screen

I select original story and damn.... I experience a lots of weird thing
Im extremey tired / exhausted tonight and dont have the energy to make a full report wich i will do in couples of hours after a good sleep

Sorry
i write to you in couples of hours with more details and best i will try to upload video with the link you gave me

comment:45 by neuromancer, 7 weeks ago

Hi Mark,

I think I found some issues in the palette decoding, but only for the spanish/french/german release. Can you please test the US demo to see if how it works in your PS3? You can download it here:

https://downloads.scummvm.org/frs/demos/private/private-eye-win-demo-us.zip

Thanks!

comment:46 by neuromancer, 7 weeks ago

Just pushed a few commits that perhaps will solve some of the issues (however, some artifacts in the intro will remain). Please try to test revision https://github.com/scummvm/scummvm/commit/3d247f33e10753a23cc6e65c7a127e0109647ee7 or later.

comment:47 by Markamiga500, 7 weeks ago

@Neuromancer

Hi
sorry for the no-reply since weeks
many things happened.

OK i will test both the demo first and after the new revision (right now)
and i will give you update in couples of minutes

Mark

comment:48 by Markamiga500, 7 weeks ago

I cannot remember wich one i need to test between

---ScummVM latest
Branch master

---ScummVM stable
Future 2.5.x

?

comment:49 by neuromancer, 7 weeks ago

You should always test the master branch, unless we some specific version to release. Remember that the latest release will be available for nightly tomorrow (but you can test the current version, just to see how it works).

by Markamiga500, 5 weeks ago

Attachment: IMG_8177.JPG added

by Markamiga500, 5 weeks ago

Attachment: IMG_8181.JPG added

by Markamiga500, 5 weeks ago

Attachment: IMG_8176.JPG added

by Markamiga500, 5 weeks ago

Attachment: IMG_8178.JPG added

by Markamiga500, 5 weeks ago

Attachment: IMG_8182.JPG added

by Markamiga500, 5 weeks ago

Attachment: IMG_8183.JPG added

comment:50 by Markamiga500, 5 weeks ago

@Neuromancer @Sev :

Hello both
Sorry if it took me so long to answer
TONIGHT I downloaded/installed/tested the ScummVM ps3-master-6dcaa7cb

I tested BOTH the DEMO and my Complete Version (BOTH REACT THE SAME)

1- the red screen at the very start under the companies logo still appear

2- the Intro cinematic is now with correct white border , correct cinematic color , speed look 1:1 per original...BUT as soon we enter the selection screen to choose between original story or variation the full screen have this red/pinky filter over the image. I choose original story and start now the cinematic have correct white "paper style border" , Correct black & white background image under the cinematic, the cinematic color are 1:1 per original , speed/audio/dialogues 1:1 also.

3- As soon the cinematic/dialogues between the private & the woman end we are presented a family picture to clic on it : the red filter appear again all over the screen! I clic on the picture then the cinematic start and EVERYTHING look/run properly again.

4- The Cinematic End , Return of the red filter all over the screen again...but the music run smooth/speed properly , i can clic on thing (barely see what im doing!)

Conclusion : This Damn Red Filter All over the screen appear only in playable portion.

I will be ready to download/test other scummvm latest branch master when you need dear friends

Mark

comment:51 by Markamiga500, 5 weeks ago

I dont know why my attached pictures appear BEFORE my latest message but at least there are there

again sorry for the delay
next time i will be able to be more quick in my reply/testing/report ;)

comment:52 by neuromancer, 5 weeks ago

Hi Mark, thanks a lot for your testing and your pictures. We are trying to debug the red/pink palette issue and hopefully we can get a solution soon.

However, if I understand this correctly, the original issue that "cinematics in Private Eye are too slow" is solved, but the red/pink filter make it unplayable, right?

comment:53 by neuromancer, 5 weeks ago

Please test commit https://github.com/scummvm/scummvm/commit/c515216cd367a1de219d119986bb202177afe36f when it is available in the daily build, to check if the palette issue is fixed.

comment:54 by Markamiga500, 5 weeks ago

im always lost when you say "Daily build" im not able to find a "daily" pkg anywhere...

the only place i found that i can download a .pkg format for the Playstation 3 is there :
https://buildbot.scummvm.org/#/dailybuilds

They only have two option to download :

-- Branch master

or

--Stable Future 2.5.x

I assume i need to download the "Branch Master"
Did your "Daily Build" you talk is included in the Branch Master 316ac2df ?

--

comment:55 by neuromancer, 5 weeks ago

https://buildbot.scummvm.org/#/dailybuilds is the correct link, we always refer to the branch master (we will later port the code to the 2.5.x release, once we confirm it works)

Did your "Daily Build" you talk is included in the Branch Master 316ac2df ?

No, you will need to wait until tomorrow to get the changes we pushed today compiled.

comment:56 by Markamiga500, 5 weeks ago

Hi

very same issue with ps3-master-99288781 downloaded/tested couples of minutes ago

Red Filter all over the screen ONLY in playable portion of the game

Mark

comment:57 by neuromancer, 2 weeks ago

Hey Mark

Happy New Year!, we are still tracking down the issue, however, we can reproduce the red filter effect inside a VM, so fixing it should be a lot faster now. Hopefully next time we ask you to run the game, it will work fine. Expect some news in the following weeks..

comment:58 by neuromancer, 2 weeks ago

I think I fix it (at least, it works fine in the VM and in my computer). Please the test daily build of https://github.com/scummvm/scummvm/commit/1a604c7bd329b756612e979018ea48e516938b12 or later (master branch).

comment:59 by Markamiga500, 2 weeks ago

Hi Neuromancer,
Happy New year !

I can download the master branch right now or i need to wait for the one after midnight ?

Mark

comment:60 by neuromancer, 2 weeks ago

You need to wait until midnight to get a more recent build.

comment:61 by Markamiga500, 2 weeks ago

Neuromancer
you just created beautiful new year gift for everyones still using their PS3 consoles

100% working properly per original version.

100% Approval for the 2.5x release ! :)

Thanks you so much !

Happy new year my friend
stay safe
Mark :)

comment:62 by neuromancer, 2 weeks ago

Resolution: fixed
Status: newclosed

Thanks to you for the testing and sorry it took longer than expected. Closing this issue.

Note: See TracTickets for help on using tickets.