AGS: Segfault when closing during intro of My Burden to Keep

[Thunderforge]

A segmentation fault can be reliably reproduced when closing during the intro sequence of My Burden to Keep.

Reproduction

1. Start ​My Burden to Keep
2. Click once to skip the company logos
3. When the first screen of the intro cutscene appears ("Oh my god, Sheriff, it's…"), click the window's close button

ScummVM will crash with a segfault. The crash is more obvious if you enable in the Options "Misc" → "Always return to the launcher when leaving a game".

Tested On

• Operating System: macOS 11.4
• ScummVM Version: macOS x64 gbaccbedf50 (2021-07-05)

Crash Report

Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
Exception Codes:       KERN_INVALID_ADDRESS at 0xffffffffffffffb8
Exception Note:        EXC_CORPSE_NOTIFY

Termination Signal:    Segmentation fault: 11
Termination Reason:    Namespace SIGNAL, Code 0xb
Terminating Process:   exc handler [24126]
    
Thread 6 Crashed:: AudioQueue thread
0   org.scummvm.scummvm           	0x0000000111f9f558 0x10e69c000 + 59782488
1   org.scummvm.scummvm           	0x0000000111fb892e 0x10e69c000 + 59885870
2   org.scummvm.scummvm           	0x0000000111fb87e8 0x10e69c000 + 59885544
3   org.scummvm.scummvm           	0x0000000111bc6c8c 0x10e69c000 + 55749772
4   org.scummvm.scummvm           	0x0000000111bc6bec 0x10e69c000 + 55749612
5   org.scummvm.scummvm           	0x00000001121cbd99 0x10e69c000 + 62061977
6   com.apple.audio.toolbox.AudioToolbox	0x00007fff2cba18f8 ClientAudioQueue::CallOutputCallback(AudioQueueBuffer*) + 292
7   com.apple.audio.toolbox.AudioToolbox	0x00007fff2cb87f86 ClientAudioQueue::FetchAndDeliverPendingCallbacks(unsigned int) + 828
8   com.apple.audio.toolbox.AudioToolbox	0x00007fff2cb87bcb _XCallbackNotificationsAvailable + 164
9   libAudioToolboxUtility.dylib  	0x00007fff2bb85fb9 mshMIGPerform + 238
10  com.apple.CoreFoundation      	0x00007fff20410104 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE1_PERFORM_FUNCTION__ + 41
11  com.apple.CoreFoundation      	0x00007fff2040ffe5 __CFRunLoopDoSource1 + 619
12  com.apple.CoreFoundation      	0x00007fff2040e66f __CFRunLoopRun + 2400
13  com.apple.CoreFoundation      	0x00007fff2040d64c CFRunLoopRunSpecific + 563
14  org.scummvm.scummvm           	0x00000001121cb89c 0x10e69c000 + 62060700
15  org.scummvm.scummvm           	0x000000011215ca71 0x10e69c000 + 61606513
16  org.scummvm.scummvm           	0x00000001121c09bc 0x10e69c000 + 62015932
17  libsystem_pthread.dylib       	0x00007fff203168fc _pthread_start + 224
18  libsystem_pthread.dylib       	0x00007fff20312443 thread_start + 15

Thread 6 crashed with X86 Thread State (64-bit):
  rax: 0x00007fbb581b1400  rbx: 0x0000600000e31540  rcx: 0x0000000000000000  rdx: 0x0000000000000000
  rdi: 0x0000600003f09888  rsi: 0x0000000000000000  rbp: 0x0000700006c4e8b0  rsp: 0x0000700006c4e890
   r8: 0x00000000000001fe   r9: 0x0000000000000000  r10: 0x00000000ffffff00  r11: 0x0000600002a1f258
  r12: 0x0000000000000002  r13: 0x0000000000001000  r14: 0x0000000000001000  r15: 0x00007fbb5992b000
  rip: 0x0000000111f9f558  rfl: 0x0000000000010206  cr2: 0xffffffffffffffb8
  
Logical CPU:     0
Error Code:      0x00000004 (no mapping for user data read)
Trap Number:     14

Thread 6 instruction stream:
  48 8b 45 f8 48 8b 00 5d-c3 66 2e 0f 1f 84 00 00  H.E.H..].f......
  00 00 00 0f 1f 44 00 00-55 48 89 e5 48 83 ec 20  .....D..UH..H.. 
  48 89 7d f8 48 8b 45 f8-83 78 18 00 48 89 45 f0  H.}.H.E..x..H.E.
  0f 84 15 00 00 00 48 8b-45 f0 8b 48 1c 3b 48 18  ......H.E..H.;H.
  b2 01 88 55 ef 0f 84 2c-00 00 00 48 8b 45 f0 48  ...U...,...H.E.H
  05 08 00 00 00 48 89 c7-e8 33 49 4f 00 48 8b 08  .....H...3IO.H..
 [48]8b 49 b8 48 89 c2 48-01 ca 48 8b 04 08 48 89  H.I.H..H..H...H.	<==
  d7 ff 50 28 88 45 ef 8a-45 ef 24 01 0f b6 c0 48  ..P(.E..E.$....H
  83 c4 20 5d c3 0f 1f 00-55 48 89 e5 31 c0 48 89  .. ]....UH..1.H.
  7d f8 48 8b 4d f8 83 79-18 00 48 89 4d f0 88 45  }.H.M..y..H.M..E
  ef 0f 84 10 00 00 00 48-8b 45 f0 8b 48 1c 3b 48  .......H.E..H.;H
  18 0f 94 c2 88 55 ef 8a-45 ef 24 01 0f b6 c0 5d  .....U..E.$....]
  
Thread 6 last branch register state not available.

[dreammaster]

Thanks for the repoort. It's now fixed.