AGS: Captain Disaster in Death Has a Million Stomping Boots - Crash when talking to speeder saleswoman

[joeraz]

The game Captain Disaster in Death Has a Million Stomping Boots crashes during the scene where you're first talking to the speeder saleswoman.

This was working previously, the last time I did testing for this game.

Running on the July 6 daily build. A savegame is attached.

[dreammaster]

I presume that this was using an old savegame rather than starting from scratch. At the time I first did the conversion of the AGS codebase, it was in a very inconsistent/unstable state.. a bunch of stuff was accidentally committed and then reverted. This looks like another case of that. In the ScriptDrawingSurface::Serialize method, the bad original code I imported into ScummVM had this:

SerializeInt((roomBackgroundNumber & 0xFFFF) | (roomMaskType << 16));

whereas, the proper line in the cleaned up codebase I re-imported a few weeks ago had this:

SerializeInt(roomBackgroundNumber);

The result is that the room number of -1 was accidentally saved as 65535, and is being incorrectly loaded as such even with the new codebase. I tried starting the game from scratch, and was able to verify that there wasn't any problem anymore of saving/loading the game and then talking to the speeder woman.