Opened 5 months ago

Closed 5 months ago

#12650 closed defect (fixed)

ScummVM for Android crashes when editing game id

Reported by: scarmonag Owned by: antoniou79
Priority: normal Component: Port: Android
Version: Keywords: backends, rename, id, domain
Cc: antoniou79 Game:

Description

When adding a new game and editing its id (for example, I delete "-cd-win" and leave only "gk1"), the app crashes back to the app drawer/desktop as soon as the OK button is pressed.

Tested on arm 64 daily builds with a Samsung Galaxy Note 9 running Android 10.

Change History (3)

comment:1 by antoniou79, 5 months ago

Cc: antoniou79 added
Keywords: backends rename id domain added
Owner: set to antoniou79
Resolution: pending
Status: newpending

As far as I can tell this is not an Android specific bug, but it won't manifest on the main Windows builds. It affects any port that makes use of the new "Backend" tab (_backendOptions for backend specific controls) and Android is one of those.

The Backend tab also appears at Game domain and its settings can override the global ones (if the user chooses so, by clicking the relevant checkbox for that).

However, as it was, when editing the game id to a new one, effectively changing the Domain name for the game specific configuration settings, the backend tab would maintain the old domain name and thus ScummVM would exit with an error of ConfigMan actions (such as removeKey) "called on non-existent domain" upon hitting OK (which calls the OptionsDialog::apply())

Should be fixed with this commit:
https://github.com/scummvm/scummvm/commit/ae5277f942abf851d3b0473acd2029cc6c5721f8

Let me know if it's fixed for you, so that we can close the ticket.

comment:2 by scarmonag, 5 months ago

I can confirm that this is now fixed in the Android daily build.

comment:3 by antoniou79, 5 months ago

Resolution: pendingfixed
Status: pendingclosed
Note: See TracTickets for help on using tickets.