SCI: PHARKAS demo, hanging MIDI notes

[eriktorbjorn]

When playing the Freddy Pharkas demo (either of the floppy ones; I don't think the CD demo has the ballad?) and using a MIDI driver (FluidSynth, in my case) if I press the "Watch the Ballad" button while the main menu music is still playing, some notes are left hanging.

I have not been able to reproduce this with AdLib or MT-32 emulation.

Nor have I been able to reproduce it with the floppy version of the full game (GOG includes both the CD and floppy versions, fortunately).

Both the demo and floppy versions do seem to ask for some sort of fade out. Oddly enough, the floppy version fades the music volume from 127 to 117, and then apparently stops fading. Maybe the music is stopped some other way. In the demo, the volume fades all the way from 127 to 0 in steps of 5.

I'll see if I can make some recordings to show what I mean.

[sluicebox]

Fixed by our hero athrxx in ​https://github.com/scummvm/scummvm/commit/2caa572f042652c7faa6b2edd394474043ab03f0