Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#12595 closed defect (fixed)

LANDS OF LORE: gamepad input doesn't work in some menus

Reported by: Wolod Owned by: athrxx
Priority: normal Component: Engine: Kyra
Version: Keywords:
Cc: Game: Lands of Lore

Description

I try to play Lands of Lore CD version with a controller. Everything works fine unless I open in-game options menu (diskette button) or any of its submenus (e.g "Load game" from title screen). When I try to click any button in these menus using gamepad nothing happens. It doesn't matter what gamepad buttons or keyboard keys I bind to LMB, result is always the same - only clicking with the real mouse works.

This issue happens on both stable v.2.2.0 and nightly build 2.3.0

Tested on Windows 10 Pro build 19042.985 64-bit and on ArkOS Final v.1.6 (it's a Linux based OS for handheld retro consoles).

Change History (6)

comment:1 by athrxx, 6 months ago

Owner: set to athrxx
Resolution: fixed
Status: newclosed

Thanks for the report.

I have made a fix for this. Unfortunately, it requires you to renew your keymapper settings in the launcher, because I split up the mapping in two parts, one for the mouse buttons and one for the keyboard keys. The reason is that during the savegame name input process the mapping for the keyboard keys should be disabled while the mapping for the mouse clicks should still remain enabled.

in reply to:  1 ; comment:2 by Wolod, 6 months ago

Replying to athrxx:

Thanks for the report.

I have made a fix for this. Unfortunately, it requires you to renew your keymapper settings in the launcher, because I split up the mapping in two parts, one for the mouse buttons and one for the keyboard keys. The reason is that during the savegame name input process the mapping for the keyboard keys should be disabled while the mapping for the mouse clicks should still remain enabled.

Thanks for the fix. But there is a one tiny problem. Your commit still wasn't included into the new daily builds. As I understand it couldn't complete a check of some sort. On GitHub it says that "Travis CI build could not complete due to an error".

comment:3 by athrxx, 6 months ago

Hiya, the commit is definitely in the repo. Travis CI is not related to our automated builds, so even if that one fails (which it didn't actually - it's just that if more than one commit comes in at the same time it will only build from the latest, in this case https://github.com/scummvm/scummvm/commit/85fd758162313b98c77b6b12d3737bcae41b9297 ) it shouldn't matter.

You could try one of these builds. These should be the latest:
https://buildbot.scummvm.org/snapshots/master/windows-x86-64-master-a3f1211f.zip
https://buildbot.scummvm.org/snapshots/master/windows-x86-master-a3f1211f.zip

in reply to:  2 ; comment:4 by Wolod, 6 months ago

Replying to Wolod:

Replying to athrxx:

Thanks for the report.

I have made a fix for this. Unfortunately, it requires you to renew your keymapper settings in the launcher, because I split up the mapping in two parts, one for the mouse buttons and one for the keyboard keys. The reason is that during the savegame name input process the mapping for the keyboard keys should be disabled while the mapping for the mouse clicks should still remain enabled.

Thanks for the fix. But there is a one tiny problem. Your commit still wasn't included into the new daily builds. As I understand it couldn't complete a check of some sort. On GitHub it says that "Travis CI build could not complete due to an error".

Ah, I see. Thanks for the explanation! So your fix was applied to the latest Raspberry Pi version too, right?

comment:5 by athrxx, 6 months ago

Interesting, I didn't even know that we had a Rasperry Pi version on the buildbot ;-)

Just looked it up, it has the same revision hash on it, so it should be the same as Windows:
https://buildbot.scummvm.org/snapshots/master/raspberrypi-master-a3f1211f.tar.xz

in reply to:  4 comment:6 by Wolod, 6 months ago

Replying to Wolod:

Replying to Wolod:

Replying to athrxx:

Thanks for the report.

I have made a fix for this. Unfortunately, it requires you to renew your keymapper settings in the launcher, because I split up the mapping in two parts, one for the mouse buttons and one for the keyboard keys. The reason is that during the savegame name input process the mapping for the keyboard keys should be disabled while the mapping for the mouse clicks should still remain enabled.

Thanks for the fix. But there is a one tiny problem. Your commit still wasn't included into the new daily builds. As I understand it couldn't complete a check of some sort. On GitHub it says that "Travis CI build could not complete due to an error".

Ah, I see. Thanks for the explanation! So your fix was applied to the latest Raspberry Pi version too, right?

Thanks a lot for your help! Happy weekend :D

Note: See TracTickets for help on using tickets.