AGS: Mac Steam games by Clifftop Games not detected when user selects .app file

[Thunderforge]

When a Mac user tries to add a LucasArts game on Steam, they can navigate to the .app file and ScummVM will detect the game. But when a Mac user tries to add an AGS game by Clifftop Games on Steam, navigating to the .app file results in ScummVM saying that no game can be found.

Expected Behavior

The user should be able to select the .app file for the Mac Steam version of the games from Clifftop Games, or any recognized game.

Current Behavior

ScummVM detects, for instance, The Fate of Atlantis.app but not KathyRain.app.

Reproduction

See also the attached animated GIF.

1. Launch a version of ScummVM that supports AGS games (tested with 5 May build)
2. Click "Add Game"
3. Navigate to ~/Library/Application Support/Steam/SteamApps/common

LucasArts game: Expected Behavior

1. Open the folder of a LucasArts game (such as Indiana Jones and the Fate of Atlantis), select the application within, and click the "Choose" button.
2. You will see that ScummVM recognizes the game.

Tested with Indiana Jones and the Fate of Atlants, Indiana Jones and the Last Crusade, Loom, and The Dig.

Clifftop Games game: Current Behavior

1. Open the folder of a Clifftop Games game (such as Kathy Rain), select the application within, and click the "Choose" button.
2. A dialog will appear saying "ScummVM could not find any game in the specified directory!"

Tested with Kathy Rain and Whispers of a Machine.

Clifftop Games game: Workaround

1. Open the folder of an AGS game (such as Kathy Rain), select the application within
2. Expand the "folder" of the application and navigate to Contents/Resources
3. Click the "Choose" button
4. The game is recognized by ScummVM

Thus the issue is not that ScummVM doesn't know about the game, it's that it doesn't treat the Mac Steam version of the game the same way as it does the Mac Steam versions of the LucasArts games.

(As an implementation issue: perhaps ScummVM should recognize that if this is a Mac and the "folder" ends in .app, then it should know to check for the existence of the necessary files in Contents/Resources before giving up).

[Thunderforge]

Animated GIF showing the issue. Two LucasArts Steam games are successfully detected, but Kathy Rain Steam is not

[sev-]

Did you try to use "Mass Add"? The thing is, that in the Mac bundles the files are usually sitting pretty deep in the subdirectories.

[criezy]

When adding mac AGS game you indeed need to navigate to the directory that contains the data files currently, and this can be quite deep inside the app bundle.
Using Mass Add may indeed help with that since it will scan multiple directory depths (although maybe not deep enough for some of the games).

For reference here are the game paths I have in my scummvm.ini.
From Steam:

Unavowed.app/Contents/Resources
KathyRain.app/Contents/Resources
A Golden Wake.app/Contents/Resources
WOAM.app/Contents/Resources

From GOG:

Mage's Initiation Reign of the Elements.app/Contents/Resources
Shivah.app/Contents/Resources/game/Shivah.app/Contents/Resources/drive_c/GOG Games/The Shivah
Order of the Thorne The King's Challenge.app/Contents/Resources/drive_c/Program Files/Infamous Quests/Order of the Thorne - TKC
Blackwell Legacy (Episode 1).app/Contents/Resources/game/Blackwell Legacy.app/Contents/Resources/drive_c/Program Files/GOG.com/Legacy
Blackwell Unbound (Episode 2).app/Contents/Resources/game/Blackwell Unbound.app/Contents/Resources/drive_c/Program Files/GOG.com/Unbound
Blackwell Convergence (Episode 3).app/Contents/Resources/game/Blackwell Convergence.app/Contents/Resources/drive_c/Program Files/GOG.com/Convergence
Blackwell Deception (Episode 4).app/Contents/Resources/game/Blackwell Deception.app/Contents/Resources/drive_c/Program Files/GOG.com/Deception
Blackwell Epiphany.app/Contents/Resources/game/Blackwell Epiphany.app/Contents/Resources/drive_c/Program Files/Blackwell Epiphany
Gemini Rue.app/Contents/Resources/game/Gemini Rue.app/Contents/Resources/drive_c/Program Files/GOG.com/Gemini Rue
Primordia.app/Contents/Resources/game/Primordia.app/Contents/Resources/drive_c/GOG Games/Primordia
Quest for Infamy.app/Contents/Resources/game/Quest For Infamy.app/Contents/Resources/drive_c/Program Files/Infamous Quests/Quest for Infamy
Resonance.app/Contents/Resources/game/Resonance.app/Contents/Resources/drive_c/Program Files/GOG.com/Resonance

Others:

King's Quest I.app/Contents/Resources/drive_c/Program Files/King's Quest I
King's Quest II.app/Contents/Resources/drive_c/Program Files/King's Quest II
King's Quest III Redux.app/Contents/Resources/drive_c/Program Files/King's Quest III Redux
Quest for Glory II.app/Contents/Resources/drive_c/Program Files/Quest for Glory II
AFragmentOfHer_v0.2.1.0_MacOSX.app/Contents/Resources/wineprefix/drive_c/winebottler

[dreammaster]

I'm changing this to an enhancement request, since it would be an enhancement to detection rather than an issue with the current one.