Opened 9 months ago

Closed 5 months ago

Last modified 4 months ago

#12499 closed defect (fixed)

SCUMM: Curse of Monkey Island Sprite Vertical Colour Artifacts

Reported by: mohabs Owned by: athrxx
Priority: normal Component: Engine: SCUMM
Version: Keywords:
Cc: Game: Monkey Island 3

Description (last modified by mohabs)

there is a noticeable difference between scummvm & original exe at the very first sprite frame of guybrush, and it is noticeable on other guybrush frames.

here a lossless screenshot captures on native 640x480, non upscaled, with 3 raw ripped sprites as a reference.
apps used: scummvm latest nightly (OGL) - dgvoodo - virtualbox (windows 95).
scummvm stable versions provide same issue, even the earliest.

Attachments (7)

dgvoodo.bmp (900.1 KB ) - added by mohabs 9 months ago.
highlight.png (125.1 KB ) - added by mohabs 9 months ago.
scummvm .bmp (900.1 KB ) - added by mohabs 9 months ago.
VirtualBox.bmp (900.1 KB ) - added by mohabs 9 months ago.
sprite 2.bmp (23.6 KB ) - added by mohabs 9 months ago.
sprite 3.bmp (23.5 KB ) - added by mohabs 9 months ago.
sprite.bmp (23.6 KB ) - added by mohabs 9 months ago.

Change History (23)

by mohabs, 9 months ago

Attachment: dgvoodo.bmp added

by mohabs, 9 months ago

Attachment: highlight.png added

by mohabs, 9 months ago

Attachment: scummvm .bmp added

by mohabs, 9 months ago

Attachment: VirtualBox.bmp added

by mohabs, 9 months ago

Attachment: sprite 2.bmp added

by mohabs, 9 months ago

Attachment: sprite 3.bmp added

by mohabs, 9 months ago

Attachment: sprite.bmp added

comment:1 by mohabs, 9 months ago

Description: modified (diff)

comment:2 by mohabs, 9 months ago

Description: modified (diff)

comment:3 by digitall, 9 months ago

Summary: monkey island 3 (COMI) sprite vertical color artifactsSCUMM: Curse of Monkey Island Sprite Vertical Colour Artifacts

comment:4 by antoniou79, 8 months ago

For more context on this ticket, here's some extra findings from the related forum thread:

https://forums.scummvm.org/viewtopic.php?p=95278#p95278

comment:5 by athrxx, 6 months ago

Owner: set to athrxx
Resolution: pending
Status: newpending

I have committed a fix. If you find the time, please test whether the rendering is now accurate.

comment:6 by AndywinXp, 6 months ago

I have tested and compared against the original exe, and indeed it appears to be fixed. Let's wait for mohabs, though

comment:7 by sev-, 5 months ago

Resolution: pendingfixed
Status: pendingclosed

in reply to:  6 comment:8 by mohabs, 4 months ago

Replying to AndywinXp:

I have tested and compared against the original exe, and indeed it appears to be fixed. Let's wait for mohabs, though

greetings.
sorry for the very late reply, i just realized the change when i was playing the new scummvm build, so i decided to check here again, and found out that you mentioned the fix.

and i can confirm that it is fixed.
however there is still some minor inaccuracy in the lemonade boy area, i think it is related to scrolling.
i will share the comparison soon with you

Last edited 4 months ago by mohabs (previous) (diff)

comment:10 by athrxx, 4 months ago

This seems to be a completely different issue. You're talking about the horizontally "shaking" background, right? (which somehow doesn't even affect Guybrush)

in reply to:  10 comment:11 by mohabs, 4 months ago

Replying to athrxx:

This seems to be a completely different issue. You're talking about the horizontally "shaking" background, right? (which somehow doesn't even affect Guybrush)

that's right, it is completely different.
however the video shows the difference between guybrush standing in the exact same position via scummvm, and the other via dgvoodo & virtual box.
so whats happening is that the camera is not in the same positioning as in the original exe, even guybrush's stand point is affected as seen.

comment:12 by athrxx, 4 months ago

Okay, I am glad that we don't really have a shaking background (and nobody caring about it for 20 years) :-).

Yes, I am pretty sure I noticed in several SCUMM games (even MI2) that the camera/actor positions are not exactly in match with the originals. I found it just too irrelevant and boring to investigate, but maybe it's time to put an end to that, too.

comment:13 by athrxx, 4 months ago

I have made a fix that should fix the inaccurate positioning. Please test if you find the time...

in reply to:  13 ; comment:14 by AndywinXp, 4 months ago

Replying to athrxx:

I have made a fix that should fix the inaccurate positioning. Please test if you find the time...

Great job, as usual! :-)

in reply to:  13 comment:15 by mohabs, 4 months ago

Replying to athrxx:

I have made a fix that should fix the inaccurate positioning. Please test if you find the time...

awesome, i tested, and indeed it got fixed.

i think now i can replay the whole game without worrying about this stuff, and just enjoy the real thing like it was meant to be!

and as a matter of fact: all games with akos seems to be fixed, cuz i tested full throttle - which had the same scaling artifacts as COMI - now fixed

Last edited 4 months ago by mohabs (previous) (diff)

in reply to:  14 comment:16 by mohabs, 4 months ago

Replying to AndywinXp:

Replying to athrxx:

I have made a fix that should fix the inaccurate positioning. Please test if you find the time...

Great job, as usual! :-)

both of you are appreciated for your passion in these

Note: See TracTickets for help on using tickets.