Opened 4 months ago

Closed 3 months ago

Last modified 3 months ago

#12377 closed defect (fixed)

WME: Issues Starting Wintermute Games

Reported by: joeraz Owned by: lolbot-iichan
Priority: normal Component: Engine: Wintermute
Version: Keywords: has-pull-request, regression
Cc: Game: Wintermute

Description

I attempted to add "Chivalry is Not Dead" in the latest daily build of ScummVM, and noticed a couple issues. First, while the game is detected, the list of detected games also lists unknown game variants for a series of seemingly random AGS games (see screenshot). Though Chivalry is Not Dead can be added correctly.

But more importantly, when I tried to run the game, it failed to start. I briefly caught a glimpse of the window for the game appear, then ScummVM just quit (or returned to the launcher when I had always return to launcher enabled). I noticed this also happened when I tried to start Corrosion: Cold Winter Waiting, though the support status for that game is a bit ambiguous.

I'm running Windows 10.

Attachments (1)

DetectionList.png (78.0 KB ) - added by joeraz 4 months ago.

Download all attachments as: .zip

Change History (10)

by joeraz, 4 months ago

Attachment: DetectionList.png added

comment:1 by angstsmurf, 4 months ago

I can confirm this on macOS Big Sur. When trying to start the game, the console will print a lot of OpenGL info, but then just reopen the ScummVM launcher menu in a weird new stretched format.

comment:2 by lolbot-iichan, 4 months ago

Thanks for reporting those issues.
I'll work on fixing them.

also lists unknown game variants for a series of seemingly random AGS games

Those games have one thing in common - they all have executable binary named "game.exe" added to detection tables.
As a workaround, you can rename game.exe binary in your "Chivalry is Not Dead" folder, it's not required for ScummVM's Wintermute.

But more importantly, when I tried to run the game, it failed to start.

As a workaround for now, can you please try selecting "Game 3D Render: Software" option for WME games? I believe that second issue is related to this mode.

comment:3 by criezy, 4 months ago

For the unknown AGS game variant, this is indeed related to some AGS games being in a "game.exe" file. We can detect if an exe file is an AGS game, and this is used in the AGS fallback detection. So maybe what we need to do (if that is possible) in the AGS engine is drop unknown variants when the fallback detection does not recognise them as AGS games.

comment:4 by joeraz, 4 months ago

I tested the workarounds you mentioned, and both of them appeared to work. Renaming the game.exe caused the other games to no longer be falsely detected, and using the Software option for the 3D renderer allowed me to start both games. Thanks.

comment:5 by lolbot-iichan, 4 months ago

So maybe what we need to do (if that is possible) in the AGS engine is drop unknown variants when the fallback detection does not recognise them as AGS games.

I'm thinking of providing a PR with a more straightforward fix this week:

  • if detection results contains at least one candidate that does not have unknown files - then display only those candidates (if it's exactly one - then autoselect it)
  • else (=if all candidates are "Unknown variant"s) - then display all candidates (if it's exactly one - then autoselect it)

This way we won't have to fix similar issues with other popular files mentioned in detection tables of very different engines (e.g. "demo.exe" at Petka's detection table, "engine.exe" at ICB's detection table)

comment:6 by lolbot-iichan, 4 months ago

I tested the workarounds you mentioned, and both of them appeared to work.

Great, I'm glad to hear that!

comment:7 by criezy, 4 months ago

I have now improved the AGS detector to avoid false positive. It should now only recognize games that actually are AGS games.

comment:8 by lolbot-iichan, 3 months ago

Keywords: has-pull-request regression added
Owner: set to lolbot-iichan
Resolution: fixed
Status: newclosed

Should be fixed at dayly builds.

Issue with detection was fixed by improving the AGS detector to avoid false positive.

Issue with starting game fixed by supporting "default" renderer:
https://github.com/scummvm/scummvm/commit/c28cff2fe0d8f5aaace44628ea1a3d4538b194cf

Please, reopen the case if you still have any issues with "Chivalry is Not Dead".

comment:9 by lolbot-iichan, 3 months ago

Summary: Issues Starting Wintermute GamesWME: Issues Starting Wintermute Games
Note: See TracTickets for help on using tickets.