Changes between Initial Version and Version 1 of Ticket #12363


Ignore:
Timestamp:
04/06/21 03:35:58 (6 weeks ago)
Author:
macca8
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #12363 – Description

    initial v1  
    77The issue here is that the Autosave file’s isAutosave flag is changed to false when the user initiates a manual overwrite of the file, because all manual saves (including to autosave) are passed an isAutosave parameter of false.
    88
    9 For scheduled autosaves, the autosave system determines the status of the file occupying the designated autosave slot by checking the value of its isAutosave flag, and only falls back to a name test if the flag hasn’t been set (refer SaveStateDescriptor::isAutosave() in /engines/savestate.cpp).
     9For scheduled autosaves, the autosave system determines the status of the file occupying the designated autosave slot by checking the value of its isAutosave flag (as _saveType), and only falls back to a name test if the flag hasn’t been set (refer SaveStateDescriptor::isAutosave() in /engines/savestate.cpp).
    1010
    1111This test currently fails if the user has initiated a manual overwrite of the Autosave file, because the autosave system incorrectly assumes that the autosave slot is occupied by a user created save file, which prevents the scheduled autosave from occurring.
     
    2020
    2121
    22 With regard to the name test comparison, I’m not sure if case is an issue or not, because all save names (including AUTOSAVE) appear in uppercase in the Myst3 Save dialog, and all save file names (except Autosave.m3s) are also in uppercase.
     22With regard to the name test comparison, I’m not sure if case is an issue or not, because all save names (including AUTOSAVE) appear in uppercase in the Myst3 Save dialog, and all save file names (except Autosave.m3s) are also in uppercase. Alternatively, if case isn't considered an issue, then the name test could be simplified to: saveName == _("Autosave").
    2323
    2424Current daily build: 2.3.0git14891-gb5804e1257 (Apr 3 2021)