Opened 4 years ago

Closed 3 years ago

#12064 closed defect (fixed)

PETKA: Subtitles "jump" (have different line heights)

Reported by: Tkachov Owned by: whiterandrek
Priority: low Component: Engine: Petka
Version: Keywords: subtitles, jump, line heights
Cc: Game: Petka 1

Description (last modified by Tkachov)

In the original game subtitles have fixed line height, thus they always appear at the same Y position. In ScummVM text labels jump from one Y position to another depending on line height, which looks weird.

Video demonstration: https://youtu.be/HHFUXRGwwKc (first 23 seconds are in ScummVM, the other are in the original).

Because of that multiline subtitles also look strange: the gap between two lines changes depending on the lines text.

Another minor issue which probably doesn't deserve a separate ticket: in ScummVM multiline subtitles are left-aligned, while in the original game these were centered.

In the attachments:

  • 01_* - superscript baselines for subtitles in ScummVM and original game;
  • 02_* - same, but for multiline subtitles;
  • 03_* - shows left align (ScummVM) vs. centered (original game);
  • petka1-ru.s17 and save2.dat are ScummVM and original game save files for the dialogue from the video;
  • petka1.s17 and save3.dat are ScummVM and original game save files for the dialogue from the 03_* screenshots.

ScummVM 2.3.0git11899-g3fb4d67b4e (Jan 16 2021 05:21:57)
Windows 10 version 20H2 64-bit
Petka 1.0.0.1 aka Red Comrades 1

To reproduce "jumping" (shown on video):

  • load the first save file;
  • select 'Talk' cursor (right click, then left click on the mouth icon);
  • click the merchant;
  • select third option and then the last one;
  • <you could click to skip speech and see how subtitles "jump">.

To reproduce multiline subtitles (shown on screenshots):

  • load the second save file;
  • select 'Talk' cursor (right click, then left click on the mouth icon);
  • click the girl;
  • select second option and then the first one;
  • <one of the subtitles would be multiline>;
  • click the girl again;
  • select second option and then the first one (it was second one before);
  • <one of the subtitles would be multiline>.

Baselines

Original game
ScummVM
Original game
ScummVM


Alignment

Original game ScummVM

Attachments (10)

01_original_subtitles.png (28.0 KB ) - added by Tkachov 4 years ago.
01_scummvm_subtitles.png (36.3 KB ) - added by Tkachov 4 years ago.
02_original_2lines.png (47.6 KB ) - added by Tkachov 4 years ago.
02_scummvm_2lines.png (427.3 KB ) - added by Tkachov 4 years ago.
03_original_center.png (396.3 KB ) - added by Tkachov 4 years ago.
petka1-ru.s17 (44.3 KB ) - added by Tkachov 4 years ago.
03_scummvm_left.jpg (526.1 KB ) - added by Tkachov 4 years ago.
save2.dat (67.3 KB ) - added by Tkachov 4 years ago.
petka1.s17 (44.5 KB ) - added by Tkachov 4 years ago.
save3.dat (67.3 KB ) - added by Tkachov 4 years ago.

Download all attachments as: .zip

Change History (13)

by Tkachov, 4 years ago

Attachment: 01_original_subtitles.png added

by Tkachov, 4 years ago

Attachment: 01_scummvm_subtitles.png added

by Tkachov, 4 years ago

Attachment: 02_original_2lines.png added

by Tkachov, 4 years ago

Attachment: 02_scummvm_2lines.png added

by Tkachov, 4 years ago

Attachment: 03_original_center.png added

by Tkachov, 4 years ago

Attachment: petka1-ru.s17 added

by Tkachov, 4 years ago

Attachment: 03_scummvm_left.jpg added

by Tkachov, 4 years ago

Attachment: save2.dat added

by Tkachov, 4 years ago

Attachment: petka1.s17 added

by Tkachov, 4 years ago

Attachment: save3.dat added

comment:1 by Tkachov, 4 years ago

Description: modified (diff)

comment:2 by whiterandrek, 4 years ago

Owner: set to whiterandrek
Resolution: pending
Status: newpending

comment:3 by whiterandrek, 3 years ago

Resolution: pendingfixed
Status: pendingclosed

fixed in #e2174c5

Note: See TracTickets for help on using tickets.