Opened 10 months ago

Closed 7 months ago

#12041 closed defect (fixed)

GUI: EDIT GAME DIALOG: Selecting <default> for the Graphics Stretch Mode doesn’t revert to default setting.

Reported by: macca8 Owned by: macca8
Priority: normal Component: GUI
Version: Keywords:
Cc: Game:

Description (last modified by macca8)

This is a follow up to the behaviour resolved in #11744. That report’s description targeted pressing Apply, but pressing OK produced similar behaviour.

I note that the fix applied involved changes to OptionsDialog::apply() exclusively - Graphics Mode & Shaders have also been adjusted - and resolved both Apply & OK situations, but only when resetting the global <default>.

Current Daily Build: 2.3.0git11719-g8ede0e39ca (Jan 2 2021)

In this case, the action is performed in the Edit Game dialog, where the change to <default> is effected by pressing OK. Other than that, the behaviour is identical (refer #11744), which includes applying the workaround of exiting & relaunching ScummVM to reset the default value.

This issue only exists when the Stretch Mode’s global setting is also <default>. If any other value is applied globally, then the game option will assume that as its <default> value, which is normal behaviour, even when overriding global graphic options. The same is true if the global and game option settings are reversed (when returning to the launcher).

Is there any reason why an Apply button can’t be added to the Edit Game dialog? I am wondering if it might offer a cleaner way of implementing the changes previously applied globally.

Change History (2)

comment:1 by macca8, 10 months ago

Description: modified (diff)

comment:2 by macca8, 7 months ago

Owner: set to macca8
Resolution: fixed
Status: newclosed

I'm closing this ticket as the underlying issue has been resolved, albeit without the need to implement an Apply button in the Edit Game dialog.

Note: See TracTickets for help on using tickets.