TWINE: No music in FLA movie

[vvs-]

There is no CD music in Twinsen's dream video. But I have music in main menu. All CD audio tracks are there as track[1-9].flac.

Also, I've noticed that there is no sound of surf in the title video, where Twinsen is flying through game title.

[mgerhardy]

The intro should be fixed in 53d6af71bd4e08c2cb7412751c05f800031f249c

[vvs-]

The sounds are now fixed, but there is still no music.

BTW, the music seems to be not CD audio after all, but probably MIDI.

[mgerhardy]

Yes, the original game played midi during cutscenes - most likely due to not trying to read the cinematic and the music from the cd at the same time.

You can find a list with midi files here: ​https://forum.magicball.net/showpost.php?p=361476&postcount=1

Which one should get played in the cutscenes?

[vvs-]

Are you suggesting that they are hardcoded? I'd expect the midi track number to be stored inside FLA file itself.

In any case it's very difficult to compare midi tracks. The very nature of midi makes the actual sound depend on the instrument samples which you have, so they will sound quite differently using different samples. Also, many tracks in LBA actually sound very similar, if not identical.

I can (vaguely) identify the track in INTROD.FLA as number lbaI2 in midi files. But that midi track is actually much longer than the video. Also, I can't say anything about other videos without playing all the game which is impractical ATM.

[mgerhardy]

That already helps - there are still a few unknown values in the fla header. Having at least an idea of the possible values might help to identify them.

Then there is entry 24 in ress.hqr which should contain fla information - but nothing is known yet about that entry afaik.

[mgerhardy]

see e.g. here: ​http://lbafileinfo.kazekr.net/index.php?title=LBA1:FLA_movies_information

[mgerhardy]

I've pushed a potential fix - but I need your feedback. Can't get midi running in dosbox - so it's impossible for me to verify on my own. I've tested the introd scene and the baffe scene when twinsen is imprisoned again in the asylum.

[mgerhardy]

oh, if anyone is testing this with a cutscene that is played while a scene is active, please keep in mind that there is still an open issue about the palette. See here: https://bugs.scummvm.org/ticket/12050

[vvs-]

Unfortunately this is not the right midi track at all. Neither are those numbers printed in debug log.

[mgerhardy]

Reverted that commit. The entry 23 of ress.hqr is for the gif animations, it contains a string with the frames and the animation names. This was integrated into the engine. But i'm still unsure where to get the midi track id from.

---snip---
introd 2 4 6 8 10
baffe 12 14
baffe2 12 14
baffe3 12 14
baffe4 12 14
bateau 16 18
bateau2 16 20
flute2 22
navette 24
templebu 26 28 30
glass2 32
surf 34
verser 36
verser2 36
capture 38 40 42 44 46
neige2 48 50 52

dragon3 100

---snap---

newlines via \r\n

Just leaving this here as a reference.

[mgerhardy]

flute2 contained an unimplemented opcode for playing a midi track 26 - this is implemented now in ​https://github.com/scummvm/scummvm/commit/fcbee4f724b5028cd1778aff375031b56b50dc40

[vvs-]

Does it suppose to fix this issue? Because there is still no music after that commit.

[vanfanel]

I can confirm there's no music during intro movie play with current GIT version.

[mgerhardy]

Which version of the game are we talking about here? And which OS are you running the game on?

[vvs-]

I can confirm this - no MIDI music in the intro movie. This is in commit d78295a8caba1e47343bc72f04a75b2ba3a4c7d6 on NixOS (Linux). Playing using USA CD version.

There is CD audio in menu and MIDI in the asylum, though. I can see the correct MIDI track 1 was selected in the source code right before the FLA movie. Still it didn't play for some reason.

[mgerhardy]

​https://github.com/scummvm/scummvm/blob/master/engines/twine/movies.cpp#L376

[mgerhardy]

The above posted line stops the music right after starting it - I suppose this call should go to mPLAY_FLA() and lPLAY_FLA() - and most likely removed from playMovie()

[mgerhardy]

Should be fixed in 6f2c6531b4e2ca1643f1521f6a08384af681f41a and in the branch-2-5

[mgerhardy]

I still only hear the music if I extracted the tracks to ogg or mp3 - the midi files don't work at all for me. But I've never managed to get the midi working on any game so far. No clue about it - so might be my side. Feedback regarding midi would be nice.

[vvs-]

Fixed, thanks!

Both MIDI and CD audio tracks are working for me. I have this line at the beginning of the ScummVM log: Use midi_mi.hqr for midi. There is yet another file midi_sb.hqr which I believe was used in DOS for SoundBlaster cards.

This particular MIDI track used in that FLA movie doesn't sound very good, though. It's much better in DOSBox. But that might be just my particular set up as well.