Opened 10 months ago

Closed 6 months ago

#12034 closed defect (fixed)

SCI: LSL1: French fan patch version not detected

Reported by: MADevil666 Owned by: sluicebox
Priority: normal Component: Engine: SCI
Version: Keywords: detection
Cc: Game: Leisure Suit Larry 1

Description

The game in 'Leisure Suit Larry in the Land of the Lounge Lizards (Floppy DOS VGA Remake)\' seems to be an unknown game variant.

Please report the following data to the ScummVM team at https://bugs.scummvm.org/ along with the name of the game you tried to add and its version, language, etc.:

Matched game IDs for the sci engine: lsl1sci

{"resource.002", 0, "3fe2a3aec0ed53c7d6db1845a67e3aa2", 1095908},
{"resource.003", 0, "ac175df0ea9a2cba57f0248651856d27", 376556},
{"resource.000", 0, "5e501a9bf8c753bf4c96158042422f00", 1938733},
{"resource.001", 0, "112648995dbc194037f1e4ed2e195910", 1063341},
{"resource.map", 0, "bbf22cacfcf6ef7e7578045fafad805d", 3337},

Change History (4)

comment:2 by digitall, 9 months ago

Component: --Other--Engine: SCI
Keywords: detection added; LSL1 FR PATCH removed
Summary: Leisure Suit Larry 1 with french fan patchSCI: LSL1: French fan patch version not detected
Type: patchdefect

comment:3 by sluicebox, 9 months ago

Thanks for reporting this. It's going to take some work before we can add this though.

First, this patch is distributed as three installers: 2.0A, 2.0B, and 2.1. The installers modify the target LSL1VGA resource volumes instead of adding SCI patch files, so this is would need to be more than just one detection entry for whichever version this is.

The bigger problem is that even if we add these entries, they won't work. If these patches are run as French under ScummVM then they will crash almost immediately with VIEW 1051 NOT FOUND. These patches took the Spanish version and modified its resources, so it only works when run as Spanish. We would have to do something to hack around that, and it's a little more complicated since this is a dual language game that can switch to English.

At the script level, LSL1:printLang must only equal English or Spanish for these patches to run.

comment:4 by sluicebox, 6 months ago

Owner: set to sluicebox
Resolution: fixed
Status: newclosed

Fixed in: https://github.com/scummvm/scummvm/commit/21b946645e4488f9dbad9ae655e0fcf4575f2391

I added the 2.1 hashes, which are the ones you provided, and a workaround so that the game works even though it needs to think that it's Spanish. French text and pictures work, and since this version includes English, you can also toggle between the languages.

This change will appear in the next daily build: https://www.scummvm.org/downloads/

Thanks again!

Note: See TracTickets for help on using tickets.