TWINE: Manual mode for agressive behaviour doesn't work as expected

[vvs-]

In manual mode space and arrows should select punches and kicks. Currently up arrow just freezes and left/right arrows both punch and rotate.

[mgerhardy]

Thanks a lot for the report.

I've just published a potential fix to master. It would be nice if you could test the next nightly build and report back.

[vvs-]

Something else is broken, it can't detect the game now :(

[vvs-]

Ok, found the reason - I've messed up permissions.

Your fix is working, thank you. But there is still one difference: in the original these actions auto repeat if you hold the keys, while in TwinE they doesn't.

[mgerhardy]

This is all about the input system refactoring to the scummvm keymapper. The issue at https://bugs.scummvm.org/ticket/12004 is related

[mgerhardy]

Movements::processBehaviourExecution uses toggleActionIfActive and thus only executes the action once.

d4ba608c77db6462de4e65fd68dc1d8a2cb3085b should fix the issue

[mgerhardy]

What I am not sure about is the fact that the actor now also rotates while pressing left right attack.

[vvs-]

Not only he rotates, but the combo with up arrow doesn't work again.

[vvs-]

BTW, in the original Twinsen slightly moves ahead at each strike, and the distance is further for kick.

[mgerhardy]

​https://github.com/scummvm/scummvm/commit/a9960cfea5ba666bbdc1935b8338ab91cca82dff Yet another attempt to fix the regression. I'm not yet sure about the slightly moves you mentioned, will investigate.

[mgerhardy]

The actors moves forward while attacking and in combination with ticket: https://bugs.scummvm.org/ticket/12046 I think this is fixed now.

[vvs-]

Twinsen still rotates while punching. And the kick using up arrow+space combo still doesn't work.

[mgerhardy]

The manual mode kick is fixed in 0da5fc1d24c3b65bd86483dd41ddf8b7e51aad98

[vvs-]

Thanks!