Switching to fullscreen and back to windowed mode captures the mouse cursor

[eriktorbjorn]

If I start ScummVM in windowed mode, hits Alt+Enter to switch to fullscreen, and then again to switch back to windowed mode, the cursor is captured. (This threw me off for a while, because the game where I first saw it had no visible mouse cursor at this point.)

From what I understand, this is because of how SdlWindow::createOrUpdateWindow(9 is implemented. In fullscreen mode, it will automatically grab the cursor (in case the fullscreen graphics doesn't actually cover the entire screen, perhaps?). When returning to windowed mode, it sees that the cursor was grabbed and assumes it should still be.

It can be released with Alt+M, of course. But is this really the intended behavior?

[macca8]

This appears to have been introduced with the latest daily build (2.3.0git9436).
I'm seeing the same behaviour when returning from a fullscreen game to a windowed Launcher.
Users will either love it or hate it, depending on their need to leave the window.

[eriktorbjorn]

Well, unless I've explicitly locked the mouse cursor to the window myself, I would think that switching from fullscreen to windowed mode is a pretty clear sign that I do want to leave the window. Or is that just me?

[macca8]

Windowed mode gives access to your desktop, and the opportunity to leave the window for any number of reasons. In this situation of switching between screen modes, then leaving, having to continually release the cursor for each exit is, in my opinion, an unnecessary burden on affected users.

[sluicebox]

I hope this isn't intentional because it ruins the program for me.

[sluicebox]

Phew, it looks like this is just an unintentional result of a refactor: ​https://github.com/scummvm/scummvm/commit/d968d22eb124a9f422d5c5ebd401135cdd41033f

[macca8]

It appears that on macOS this change in behaviour is restricted to the 64 bit build. The 32 bit build is unaffected on both macOS 10.6.8 & 10.11.6.

[ccawley2011]

This should be fixed by ​PR #2554.