Changes between Initial Version and Version 1 of Ticket #11544, comment 7


Ignore:
Timestamp:
08/01/20 06:33:42 (4 years ago)
Author:
sluicebox

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #11544, comment 7

    initial v1  
    11Yup, this is a regression from my fix in January for a Hoyle4 palette bug: https://github.com/scummvm/scummvm/commit/3de471de36f22c12604d60be16f270c594510a56
    22
    3 This is a bummer, that fix took a lot of work. (I must have patched the script to instantly the card game win?) At a high level, I remember that I correctly identified the problem where ScummVM wasn't doing what SSCI did and addressed it, but I also remember seeing a surprising number of things in the ScummVM code structure that didn't match what was going on in SSCI at all. I hope I just goofed a line but I fear this is just a fix that has exposed another underlying bug or interpreter version difference.
     3This is a bummer, that fix took a lot of work. (I must have patched the script to instantly win the card game?) At a high level, I remember that I correctly identified the problem where ScummVM wasn't doing what SSCI did and addressed it, but I also remember seeing a surprising number of things in the ScummVM code structure that didn't match what was going on in SSCI at all. I hope I just goofed a line but I fear this is just a fix that has exposed another underlying bug or interpreter version difference.