Opened 4 months ago

Closed 4 months ago

#11522 closed defect (fixed)

ultima4 - problem compiling with makeMP3Stream not being known

Reported by: rubyFeedback Owned by: dreammaster
Priority: normal Component: --Unset--
Keywords: Cc:
Game:

Description

make

C++ engines/ultima/ultima4/sound/music.o

/home/Temp/rbt/scummvm-22.06.2020/engines/ultima/ultima4/sound/music.cpp: In member function ‘bool Ultima::Ultima4::Music::startMusic(const Common::String&)’:
/home/Temp/rbt/scummvm-22.06.2020/engines/ultima/ultima4/sound/music.cpp:134:52: error: ‘makeMP3Stream’ is not a member of ‘Audio’; did you mean ‘makeModXmS3mStream’?

134 | Audio::SeekableAudioStream *audioStream = Audio::makeMP3Stream(

|
| makeModXmS3mStream

make: * engines/ultima/ultima4/sound/music.o Error 1

This was a git clone checkout from 22nd June 2020.

Perhaps that bug is already known or fixed. I report it anyway. (I actually managed to compile this on my slackware system, but on my current fedora system that failed, which surprised me. May be the gcc in fedora?)

Change History (1)

comment:1 by dreammaster, 4 months ago

Owner: set to dreammaster
Resolution: fixed
Status: newclosed

I think I've fixed the problem. If the MAD library isn't installed, the call to makeMP3Stream should be disabled, and it wasn't previously. Of course, without it, it means that the MP3 audio won't play, but at least ScummVM should compile again.

Note: See TracTickets for help on using tickets.