Opened 5 years ago

Closed 4 months ago

Last modified 4 months ago

#11428 closed feature request (fixed)

macOS: Change default savegame location for macOS

Reported by: Thunderforge Owned by: criezy
Priority: normal Component: Port: Mac OS X
Version: Keywords: saving
Cc: Game:

Description

In response to #11427 involving all sorts of issues if users deny ScummVM permission to access the Documents folder, I would like to change the savegame location from ~/Documents/ScummVM Savegames to ~/Library/Application Support/ScummVM/Savegames, which is the recommended location according to Apple's developer guidelines:

Contains all app-specific data and support files. These are the files that your app creates and manages on behalf of the user and can include files that contain user data.

This will prevent new users from experiencing the issue since ScummVM will not need access to Documents, meaning users will not be prompted. (No special permissions are needed to access Application Support).

A migration like this is similar to one performed on Windows around 2012 in which users were directed to run this script. This was a manual process and ideally we would want to come up with something more elegant and automated, such as ScummVM detecting if a migration needs to happen for existing users while preventing the need to check the Documents folder for any existing users.

Change History (6)

comment:1 by somaen, 3 years ago

Sounds good, after Documents started defaulting to iCloud there's even some oddities if permissions ARE given, so would be good to move the location.

comment:2 by sev-, 4 months ago

Cross-referencing #11427

comment:3 by criezy, 4 months ago

I created a pull request for the change: https://github.com/scummvm/scummvm/pull/6279

comment:4 by criezy, 4 months ago

In faf7437e:

MACOS: Change default savepath to use the Application Support folder

The default savepath on macOS used to be in the user Document folder.
However ScummVM requires special permission to access that folder,
and if the user denied it, this caused various issues.
This implement ticket #11428.

This commit also contains migration code that that old configs that
used the default path are set explicitly to use the old default path.
So the change of savepath will only be for new users.

comment:5 by criezy, 4 months ago

Owner: set to criezy
Resolution: fixed
Status: newclosed

comment:6 by criezy, 4 months ago

In 365653e7:

MACOS: Change default savepath to use the Application Support folder

The default savepath on macOS used to be in the user Document folder.
However ScummVM requires special permission to access that folder,
and if the user denied it, this caused various issues.
This implement ticket #11428.

This commit also contains migration code that that old configs that
used the default path are set explicitly to use the old default path.
So the change of savepath will only be for new users.

Note: See TracTickets for help on using tickets.