Opened 4 years ago
Closed 2 years ago
#11422 closed defect (fixed)
SCI: QfG3 - Bazaar bargain and/or purchase messages not clickable (race condition?)
| Reported by: | lwcorp | Owned by: | sluicebox |
|---|---|---|---|
| Priority: | normal | Component: | Engine: SCI |
| Version: | Keywords: | original | |
| Cc: | Game: | Quest for Glory 3 |
Description (last modified by )
When you bargain or purchase goods in the bazaar, you can't click through the messages, which makes shopping very slow. Those messages just pass on their own eventually. Please make them clickable like all regular dialog messages.
This includes bargaining, payment confirmations and any dialog in between.
Sometimes it does let you click, which makes me think if it waits for the background music to end for some reason.
I've tried it in the latest Windows 64 build, v2.2.0git4593-gf531eba971 (Apr 20 2020 05:59:17)
Attachments (2)
Change History (6)
by , 4 years ago
| Attachment: | image-20200411-005859.png added |
|---|
comment:1 by , 4 years ago
| Description: | modified (diff) |
|---|
comment:2 by , 4 years ago
| Description: | modified (diff) |
|---|
comment:3 by , 4 years ago
| Summary: | QFG3: You can't click through bazarr bargain and/or purchase dialogs → SCI: QfG3 - Bazaar bargain and/or purchase messages not clickable (race condition?) |
|---|
comment:4 by , 2 years ago
| Keywords: | original added; bargain removed |
|---|---|
| Owner: | set to |
| Resolution: | → fixed |
| Status: | new → closed |
Fixed in: https://github.com/scummvm/scummvm/commit/2029c31e2b57f8e97bb5a5bc9c4294d1a4a230fa
The barter event loop retrieved input events twice per iteration, so it was luck as to which one retrieved the click. If it was the second then the click would be processed. If it was the first then the click would be discarded and replaced with a null event by the second. We've seen this same bug in other SCI games and patched them.
Thanks for reporting this!
Sample unclickable message