Opened 8 weeks ago

Closed 8 weeks ago

#11416 closed defect (fixed)

GUI: Changing SCI game ID crashes, regression from Custom engine settings

Reported by: sluicebox Owned by: bgK
Priority: normal Component: GUI
Keywords: Cc:
Game:

Description

A recent change causes an error() when renaming an SCI game ID in the GUI:

ConfigManager::set(disable_dithering,false,iceman) called on non-existent domain!

In the above example I tried renaming the game ID "iceman" to "icemann".

I bisected it to one of two commits from PR 2164: https://github.com/scummvm/scummvm/pull/2164

f6bb3af12afe60183afdf1d1d12401674b2552e6 KEYMAPPER: Use OptionsContainerWidget for the remap widget
bcfb7145fac9a712595e81efd5eaf2bd1230ddac GUI: Allow engines to define a fully custom tab in the edit game dialog

The first commit doesn't build so I'm not sure which introduced the error, though the commit titles suggest the second.

To reproduce: select an SCI game, click Edit Game, change the game ID by adding a single character and click OK.

This doesn't affect every engine, but it at least affects every SCI/SCI32 game I've tried.

Mingw and msbuild builds on Win7.

Change History (1)

comment:1 by bgK, 8 weeks ago

Owner: set to bgK
Resolution: fixed
Status: newclosed

Thank you for your report this is fixed by commit f7efd3c.

Note: See TracTickets for help on using tickets.