Opened 4 years ago
Closed 3 years ago
#11339 closed defect (fixed)
BLADERUNNER: McCoy's TV's voices are at the wrong audio channel
| Reported by: | IlDucci | Owned by: | antoniou79 |
|---|---|---|---|
| Priority: | normal | Component: | Engine: Bladerunner |
| Version: | Keywords: | audio, stereo, | |
| Cc: | Game: | Blade Runner |
Description
During Act 1, when going to McCoy's bedroom and checking on the TV, the Newscaster's voice was panned to the right Stereo channel, but the TV is physically on the left. This might be related with the fact that the other place where the Newscaster can be heard, Police Station's 2nd Floor, has the TV on the right side.
I'm using Win7 x64, version 2.2.0git2888-g8ab9c8ec77, playing in Windowed mode. Using the GOG download of the official Spanish version, with the Restored Content mode enabled.
Change History (4)
comment:1 by , 4 years ago
comment:2 by , 3 years ago
| Owner: | set to |
|---|---|
| Priority: | low → normal |
| Resolution: | → pending |
| Status: | new → pending |
I've pushed a fix for this issue:
https://github.com/scummvm/scummvm/commit/4dcbd071488b305389c3d278aa5598ef3d11bd3d
The bad balances are corrected (overridden) explicitly in actor.cpp on a case by case basis.
The fix covers more cases than just the TV sounds, such as the phone calls, machine voices, dispatch calls, and attaches Lance voice to Luther (since they share body and only Luther actually is connected to the twins model).
If the TS @IlDucci can confirm the issue is fixed, or if no feedback is provided till after the weekend (early July 2021), I'll be closing this report as fixed.
comment:3 by , 3 years ago
I've tested and confirmed that the fix works in the particular situation I have mentioned via Windows nightly 68f59315. Other situations have not been tested.
comment:4 by , 3 years ago
| Resolution: | pending → fixed |
|---|---|
| Status: | pending → closed |
Ok, that should be enough to close this ticket.
This is a more general issue in the sense that there's no mechanism in place to detect that an actor that speaks a quote (in this case the newscaster and possible interviewees like Guzza, Kolvig, Tyrel) is not actually in the room, because it is an object in the room that does the "speaking".
One way to resolve this would be to explicitly check for all known such cases and use a proper (per case) pan value for each one. I'm in favor of this solution, but it will take some time.
The other way would be to implement a mechanism to specify that the actor speech is coming from a scene object and then use the (2d screen) co-ordinates for that object as a pan value. Not a big fan of this solution, as it seems to be more hassle for little reward.