BACKENDS: MacOSX - Dark Mode is not supported

[Thunderforge]

​Dark Mode is a feature for macOS 10.14 (Mojave) and later. Unfortunately, ScummVM doesn't support it.

To reproduce:

1. Enable dark mode in macOS (see link above)
2. Open ScummVM
3. Note that the title bar is white, rather than dark like the rest of macOS
4. Click "Add Game…"
5. Note that the file picker is white, rather than dark like the rest of macOS

[Thunderforge]

Screenshot showing ScummVM not supporting macOS Dark Mode

[criezy]

This is likely related to the fact we are using an older macOS SDK to build ScummVM. Indeed the Apple Developer documentation indicates that the system automatically opts in any app linked against the macOS 10.14 or later SDK to both light and dark appearances. There is a way to opt in when using an older SDK by setting the NSRequiresAquaSystemAppearance key to NO in the Info.plist file. I will take a look at this a bit later when I find the time to check that ScummVM behaves properly in Dark Mode.

Some more information:

• ​https://developer.apple.com/documentation/xcode/supporting_dark_mode_in_your_interface?language=objc
• ​https://developer.apple.com/documentation/appkit/nsappearancecustomization/choosing_a_specific_appearance_for_your_macos_app?language=objc

[criezy]

I have now tested that ScummVM works properly when opting in for the dark mode on macOS 10.15, and this was committed in 485e8be.

[criezy]

I am reopening this bug as the addition of the NSRequiresAquaSystemAppearance key in the Info.plist file has been reverted. So we are lacking again dark mode support.

The issue is that it causes a blurry display for users with a Retina screen on macOS Mojave and Catalina. You can see details of the issue in bug #11430. I think the blurry display is a more serious issue than not supporting the dark theme.

[dwatteau]

Hi,

As per https://bugs.scummvm.org/ticket/11430#comment:17, I think it could be possible to try enabling Dark Mode again (I can help you with some tests if necessary).

I'm keeping the details in the other ticket, though, since there are a lot of interactions between the blurriness bug on Retina displays, Dark Mode, SDK versions, SDL2 and so on.

[criezy]

Dark mode as been reenabled with pull request #2714 (thanks to dwatteau).