Opened 17 months ago

Closed 4 weeks ago

Last modified 3 weeks ago

#11290 closed feature request (fixed)

FM-TOWNS: Enable aspect ratio correction

Reported by: elvisish Owned by: sev-
Priority: normal Component: Engine: SCUMM
Version: Keywords: fm-townes, scumm, aspect ratio
Cc: Game: Zak McKracken

Description

This was requested 14 years ago but was ultimately rejected: https://sourceforge.net/p/scummvm/feature-requests/266/

The FM Townes games are presented at 320x200 and leaves a 40 pixel black gap at the bottom of the screen. The game looks squashed and doesn't match any other SCUMM game that uses Mode 13h and stretches the pixels 20% taller so the aspect ratio is correct.

It was rejected on the grounds that The original games were intended to be squashed, however as a commented mentioned, the original games were never intended to use HQ or SAI filters.

Change History (8)

comment:1 by ZvikaZ, 13 months ago

This feature was implemented and waits for volunteers to test (just play...) in order to send as PR.
See discussion at https://forums.scummvm.org/viewtopic.php?p=88663#p88663

TL;DR

git clone https://github.com/ZvikaZ/scummvm
git checkout z_zm_height_200_v7

I'm mainly interested in Loom testing (as it's the most problematic), but reports for bugs (or their absence) for any of the games will be welcomed.

comment:2 by sev-, 4 weeks ago

Owner: set to sev-
Resolution: fixed
Status: newclosed

ZvikaZ' PR has been merged. It is now implemented for all games besides Loom.

comment:3 by elvisish, 4 weeks ago

Resolution: fixed
Status: closednew

Why has it been implemented for all games besides Loom? I played through and Loom seemed to work fine.

comment:4 by sev-, 4 weeks ago

Resolution: fixed
Status: newclosed

You may find some details here: https://github.com/scummvm/scummvm/pull/2913

And why did you reopen the bugreport?

comment:5 by elvisish, 4 weeks ago

And why did you reopen the bugreport?

Because it's not been implemented for Loom.

comment:6 by bluegr, 4 weeks ago

From the forum post:
"Loom - used the extra 40 pixels for various things! For example, the items name line, the "note box" in practice mode, text on Cygna's grave. Who knows what else?"

So we can't cut the bottom black bar in the FM-TOWNS version of Loom, as it's actually used by this game version.

comment:7 by ZvikaZ, 4 weeks ago

Actually, I have a PR ready to be sent, that adds support for Loom, as well. I'm just waiting for confirmation that it's indeed working well, from the game's start to the end.

I've asked for help on testing at that forum thread, and no one had told me that he has successfully completed the game. That's why I've decided to split out Loom support.

Once I'll get that confirmation, I'll happily send that PR.

comment:8 by ZvikaZ, 3 weeks ago

Elvisish, the PR is ready, I'm just waiting for your confirmation.

Note: See TracTickets for help on using tickets.