Opened 4 years ago

Closed 4 years ago

#11258 closed defect (fixed)

BLADERUNNER: Save thumbnail not endian safe

Reported by: bgK Owned by: peterkohaut
Priority: normal Component: Engine: Bladerunner
Version: Keywords:
Cc: antoniou79 Game: Blade Runner


ScummVM 773295842ac5cae66da0361d6c4914faee80fb00.

When creating a save on a big endian system, and then transferring it to a little endian system, the thumbnail appears with incorrect colors in ScummVM's load dialog.

Attachments (1)

bladerunner-win.007 (24.3 KB ) - added by bgK 4 years ago.
Save created on a BE system

Download all attachments as: .zip

Change History (5)

by bgK, 4 years ago

Attachment: bladerunner-win.007 added

Save created on a BE system

comment:1 by peterkohaut, 4 years ago

thumbnail is converted from rgb555 on be and stored as a array of bytes, then it is read as array of bytes and converted to rgb555 but on le 2 bytes inside of every pixel are swapped. i'll fix that

comment:2 by antoniou79, 4 years ago

Cc: antoniou79 added

comment:3 by peterkohaut, 4 years ago

fixed in 3619b613bcf92386c62b4c23fed62502bbdd712d but it will only apply for future save games. saves made on little endian system should work as before, but on big endian format was changed.

comment:4 by peterkohaut, 4 years ago

Owner: set to peterkohaut
Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.